chore!: Drop Ruby 2.7 and 3.0, add Ruby 3.3#91
Merged
josecolella merged 3 commits intoopen-feature:mainfrom Jan 18, 2024
maxveldink:maxveldink/drop-ruby-2.7-and-3.0
Merged
chore!: Drop Ruby 2.7 and 3.0, add Ruby 3.3#91josecolella merged 3 commits intoopen-feature:mainfrom maxveldink:maxveldink/drop-ruby-2.7-and-3.0
josecolella merged 3 commits intoopen-feature:mainfrom
maxveldink:maxveldink/drop-ruby-2.7-and-3.0
Conversation
BREAKING CHANGE: Ruby 2.7 and Ruby 3.0 are now older than three years old at this point. Instead of continuing to support them, let's only support N-2 versions. Signed-off-by: Max VelDink <maxveldink@gmail.com>
Signed-off-by: Max VelDink <maxveldink@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 6 6
Lines 91 91
=======================================
Hits 90 90
Misses 1 1 ☔ View full report in Codecov by Sentry. |
josecolella
approved these changes
Jan 18, 2024
beeme1mr
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Since Ruby 2.7 and 3.3 are both older than three years now, we should consider dropping support and targeting N-2 (since Ruby 3.3 is so new and a few known issues are being fixed in the next patch version of 3.3). I also added a
.tool-versionsfile as an optional change for easier ASDF support, but can remove that if we'd like.Follow-up Tasks
This will need to be released in a major version bump.