fix: Allow string values for FlagEvaluationDetails.reason and FlagResolutionDetails.reason#264
Conversation
…gResolutionDetails.reason` Signed-off-by: Matthew Keeler <[email protected]>
7b86983 to
e38c4a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
=======================================
Coverage 93.89% 93.89%
=======================================
Files 16 16
Lines 442 442
=======================================
Hits 415 415
Misses 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lukas-reining
left a comment
There was a problem hiding this comment.
Not a huge python expert but the change and tests look good!
federicobond
left a comment
There was a problem hiding this comment.
Hi @keelerm84! Thank you for your contribution. Change LGTM, but I am lost on what the test is supposed to assert.
If it's just a type check then it should be already covered by mypy. Would any of the tests break if you reverted the type change?
Signed-off-by: Matthew Keeler <[email protected]>
d23d9a2 to
d35a2dd
Compare
That's a good point. I've removed the useless test and will rely on mypy as suggested. |
Signed-off-by: OpenFeature Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR
Expands the types allowed for
reasononFlagEvaluationDetailsandFlagResolutionDetailsto include bothReasonandstrtypes.Related Issues
Fixes #262
Notes
Related to spec issue: open-feature/spec#236