feat!: remove ctx transformer, add provider hooks #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
toddbaert
commented
Aug 9, 2022
toddbaert
commented
- remove context transformer
- adds provider hooks
- updates to new hook ordering
- updates tests accordingly, included referenced spec numbers
toddbaert
requested review from
beeme1mr,
benjiro,
james-milligan,
justinabrahms and
weyert
toddbaert
changed the title
toddbaert
commented
Aug 9, 2022
| typeof this.provider.contextTransformer === 'function' | ||
| ? await this.provider.contextTransformer(mergedContext) | ||
| : mergedContext; | ||
| const frozenContext = await this.beforeHooks(allHooks, hookContext, options); |
Member
Author
There was a problem hiding this comment.
chose this name because the context object is actually frozen (immutable here) after the before hooks have run...
Codecov Report
@@ Coverage Diff @@
## main #148 +/- ##
==========================================
+ Coverage 99.10% 99.53% +0.42%
==========================================
Files 9 9
Lines 446 426 -20
Branches 62 61 -1
==========================================
- Hits 442 424 -18
+ Misses 4 2 -2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
toddbaert
commented
Aug 9, 2022
BREAKING CHANGE: context transformer and related interfaces removed. Signed-off-by: Todd Baert <[email protected]>
beeme1mr
approved these changes
Aug 10, 2022
Member
Author
|
/publish |
toddbaert
changed the title
toddbaert
changed the title
toddbaert
changed the title
Member
Author
|
Tested this in the playground, looks good. |
This was referenced Aug 10, 2022
toddbaert
pushed a commit
that referenced
this pull request
Sep 20, 2022
🤖 I have created a release *beep* *boop* --- ## [0.4.0](js-sdk-v0.3.2...js-sdk-v0.4.0) (2022-09-20) ### ⚠ BREAKING CHANGES * improve generic type accuracy (#224) * convert to chainable methods (#221) * remove flag evaluation options from the provider interface (#185) * context transformer and related interfaces removed. ### Features * add client context mutation ([#207](#207)) ([5b0442a](5b0442a)) * add logger ([#219](#219)) ([763f167](763f167)) * convert to chainable methods ([#221](#221)) ([5253ad9](5253ad9)) * improve generic type accuracy ([#224](#224)) ([12230a5](12230a5)) * remove ctx transformer, add provider hooks ([#148](#148)) ([260432c](260432c)) * remove flag evaluation options from the provider interface ([#185](#185)) ([e9852e4](e9852e4)), closes [#183](#183) ### Bug Fixes * Add no-op tests ([#99](#99)) ([a341f5c](a341f5c)) * Dont push experiemental branches ([#101](#101)) ([0a7a5ec](0a7a5ec)) * Fix publish command ([#103](#103)) ([4742ef1](4742ef1)) * Fixing error with setProvider type ([#121](#121)) ([df5d214](df5d214)) * update the client to conform to the provider interface ([#187](#187)) ([f1edb29](f1edb29)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.