Skip to content

chore: remove comment about summing to 100 #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beeme1mr merged 1 commit into from
Nov 4, 2024
Merged

chore: remove comment about summing to 100 #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions json/targeting.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,8 +455,7 @@
}
},
"fractionalWeightArg": {
"$comment": "if we remove the \"sum to 100\" restriction, update the descriptions below!",
"description": "Distribution for all possible variants, with their associated weighting out of 100.",
"description": "Distribution for all possible variants, with their associated weighting.",
"type": "array",
"minItems": 1,
"maxItems": 2,
Expand All @@ -466,7 +465,7 @@
"type": "string"
},
{
"description": "Weighted distribution for this variant key (must sum to 100).",
"description": "Weighted distribution for this variant key.",
"type": "number"
}
]
Expand Down
8 changes: 2 additions & 6 deletions json/targeting.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,11 +380,7 @@ definitions:
- $ref: "#/definitions/semVerString"
- $ref: "#/definitions/varRule"
fractionalWeightArg:
$comment: if we remove the "sum to 100" restriction, update the descriptions
below!
description:
Distribution for all possible variants, with their associated weighting
out of 100.
description: Distribution for all possible variants, with their associated weighting.
type: array
minItems: 1
maxItems: 2
Expand All @@ -393,7 +389,7 @@ definitions:
If this bucket is randomly selected, this string is used to as
a key to retrieve the associated value from the "variants" object.
type: string
- description: Weighted distribution for this variant key (must sum to 100).
- description: Weighted distribution for this variant key.
type: number
fractionalOp:
type: array
Expand Down