Skip to content

Commit fbac8ce

Browse files
refactor: change the case of the flag manifest to camel case. (#19)
<!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR Changes the case of the flag manifest to camel case. --------- Signed-off-by: Florin-Mihai Anghel <fanghel@google.com> Signed-off-by: Florin-Mihai Anghel <44744433+anghelflorinm@users.noreply.github.com>
1 parent aa9d3b0 commit fbac8ce

File tree

3 files changed

+13
-22
lines changed

3 files changed

+13
-22
lines changed

docs/schema/v0/flag_manifest.json

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,16 @@
3636
"$ref": "#/$defs/objectType"
3737
}
3838
],
39-
"required": ["flag_type", "default_value"]
39+
"required": ["flagType", "defaultValue"]
4040
},
4141
"booleanType": {
4242
"type": "object",
4343
"properties": {
44-
"flag_type": {
44+
"flagType": {
4545
"type": "string",
4646
"enum": ["boolean"]
4747
},
48-
"default_value": {
48+
"defaultValue": {
4949
"type": "boolean"
5050
},
5151
"description": {
@@ -57,11 +57,11 @@
5757
"stringType": {
5858
"type": "object",
5959
"properties": {
60-
"flag_type": {
60+
"flagType": {
6161
"type": "string",
6262
"enum": ["string"]
6363
},
64-
"default_value": {
64+
"defaultValue": {
6565
"type": "string"
6666
},
6767
"description": {
@@ -73,11 +73,11 @@
7373
"integerType": {
7474
"type": "object",
7575
"properties": {
76-
"flag_type": {
76+
"flagType": {
7777
"type": "string",
7878
"enum": ["integer"]
7979
},
80-
"default_value": {
80+
"defaultValue": {
8181
"type": "integer"
8282
},
8383
"description": {
@@ -89,11 +89,11 @@
8989
"floatType": {
9090
"type": "object",
9191
"properties": {
92-
"flag_type": {
92+
"flagType": {
9393
"type": "string",
9494
"enum": ["float"]
9595
},
96-
"default_value": {
96+
"defaultValue": {
9797
"type": "number"
9898
},
9999
"description": {
@@ -105,11 +105,11 @@
105105
"objectType": {
106106
"type": "object",
107107
"properties": {
108-
"flag_type": {
108+
"flagType": {
109109
"type": "string",
110110
"enum": ["object"]
111111
},
112-
"default_value": {
112+
"defaultValue": {
113113
"type": "object"
114114
},
115115
"description": {

src/input.json

Lines changed: 0 additions & 9 deletions
This file was deleted.

src/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,14 @@ func unmarshalFlagManifest(data []byte, supportedFlagTypes map[generator.FlagTyp
6363
}
6464
for flagKey, iFlagData := range flags {
6565
flagData := iFlagData.(map[string]interface{})
66-
flagTypeString := flagData["flag_type"].(string)
66+
flagTypeString := flagData["flagType"].(string)
6767
flagType := stringToFlagType[flagTypeString]
6868
if !supportedFlagTypes[flagType] {
6969
log.Printf("Skipping generation of flag %q as type %v is not supported for this language", flagKey, flagTypeString)
7070
continue
7171
}
7272
docs := flagData["description"].(string)
73-
defaultValue := getDefaultValue(flagData["default_value"], flagType)
73+
defaultValue := getDefaultValue(flagData["defaultValue"], flagType)
7474
btData.Flags = append(btData.Flags, &generator.FlagTmplData{
7575
Name: flagKey,
7676
Type: flagType,

0 commit comments

Comments
 (0)