Full coverage

Author: paescuj

.github/workflows/test.yml

@@ -56,7 +56,7 @@ jobs:
         run: pnpm install && pnpm add --global concurrently
 
       - name: Build & Test
-        run: concurrently --prefix none --group "pnpm:build" "pnpm:test" "pnpm:test:smoke"
+        run: concurrently --prefix none --group "pnpm:build" "pnpm:test --coverage" "pnpm:test:smoke"
 
       - name: Submit coverage
         uses: coverallsapp/github-action@master

package.json

@@ -36,7 +36,7 @@
     "lint:fix": "pnpm run lint --fix",
     "prepublishOnly": "safe-publish-latest && pnpm run build",
     "report-coverage": "cat coverage/lcov.info | coveralls",
-    "test": "vitest --project unit --coverage",
+    "test": "vitest --project unit",
     "test:smoke": "vitest run --project smoke",
     "prepare": "husky"
   },

src/assert.spec.ts

@@ -0,0 +1,35 @@
+import { afterEach, describe, expect, it, vi } from 'vitest';
+
+import { assertDeprecated } from './assert';
+
+describe('#assertDeprecated()', () => {
+    const consoleMock = vi.spyOn(console, 'warn').mockImplementation(() => {});
+
+    afterEach(() => {
+        vi.clearAllMocks();
+    });
+
+    it('prints warning with name and message when condition is false', () => {
+        assertDeprecated(false, 'example-flag', 'This is an example message.');
+
+        expect(consoleMock).toHaveBeenLastCalledWith(
+            '[concurrently] example-flag is deprecated. This is an example message.',
+        );
+    });
+
+    it('prints same warning only once', () => {
+        assertDeprecated(false, 'example-flag', 'This is an example message.');
+        assertDeprecated(false, 'different-flag', 'This is another message.');
+
+        expect(consoleMock).toBeCalledTimes(1);
+        expect(consoleMock).toHaveBeenLastCalledWith(
+            '[concurrently] different-flag is deprecated. This is another message.',
+        );
+    });
+
+    it('prints nothing if condition is true', () => {
+        assertDeprecated(true, 'example-flag', 'This is an example message.');
+
+        expect(consoleMock).not.toHaveBeenCalled();
+    });
+});

src/assert.ts

@@ -5,7 +5,7 @@ const deprecations = new Set<string>();
  * The message is printed only once.
  */
 export function assertDeprecated(check: boolean, name: string, message: string) {
-    if (!check) {
+    if (!check && !deprecations.has(name)) {
         // eslint-disable-next-line no-console
         console.warn(`[concurrently] ${name} is deprecated. ${message}`);
         deprecations.add(name);

src/command-parser/command-parser.ts renamed to src/command-parser/command-parser.d.ts

@@ -1,7 +1,7 @@
 import { quote } from 'shell-quote';
 
 import { CommandInfo } from '../command';
-import { CommandParser } from './command-parser';
+import type { CommandParser } from './command-parser';
 
 /**
  * Replace placeholders with additional arguments.

src/command-parser/expand-arguments.ts

@@ -1,5 +1,5 @@
 import { CommandInfo } from '../command';
-import { CommandParser } from './command-parser';
+import type { CommandParser } from './command-parser';
 
 /**
  * Expands shortcuts according to the following table:

src/command-parser/expand-shortcut.ts

@@ -182,7 +182,7 @@ describe.each(['npm run', 'yarn run', 'pnpm run', 'bun run', 'node --run'])(
 
             expect(
                 parser.parse({
-                    name: '',
+                    name: 'watch-*',
                     command: `${command} watch-*`,
                 }),
             ).toEqual([

src/command-parser/expand-wildcard.spec.ts

@@ -3,7 +3,7 @@ import fs from 'fs';
 import { CommandInfo } from '../command';
 import JSONC from '../jsonc';
 import { escapeRegExp } from '../utils';
-import { CommandParser } from './command-parser';
+import type { CommandParser } from './command-parser';
 
 // Matches a negative filter surrounded by '(!' and ')'.
 const OMISSION = /\(!([^)]+)\)/;
@@ -102,7 +102,8 @@ export class ExpandWildcard implements CommandParser {
                     return;
                 }
 
-                const [, match] = wildcardRegex.exec(script) || [];
+                const result = wildcardRegex.exec(script);
+                const match = result?.[1];
                 if (match !== undefined) {
                     return {
                         ...commandInfo,

src/command-parser/expand-wildcard.ts

@@ -107,6 +107,14 @@ describe('#start()', () => {
         expect(command.stdin).toBe(process.stdin);
     });
 
+    it('handles process with no stdin', () => {
+        process.stdin = null;
+        const { command } = createCommand();
+        command.start();
+
+        expect(command.stdin).toBe(undefined);
+    });
+
     it('changes state to started', () => {
         const { command } = createCommand();
         const spy = subscribeSpyTo(command.stateChange);