feat: ISBN validation #1097
feat: ISBN validation #1097
Conversation
Signed-off-by: ysknsid25 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces ISBN validation functionality for the library management system, allowing the verification of both ISBN-10 and ISBN-13 formats when registering books. Key changes include adding new validation logic in the ISBN action, comprehensive test cases for the new functionality, and an update to the API menu to expose the ISBN endpoint.
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| library/src/actions/isbn/isbn.test-d.ts | Adds TypeScript type tests for ISBN action object |
| library/src/actions/isbn/isbn.test.ts | Provides tests for both valid and invalid ISBN datasets |
| library/src/actions/isbn/isbn.ts | Implements the ISBN validation and related documentation |
| library/src/actions/isbn/index.ts | Exports the ISBN action |
| website/src/routes/api/menu.md | Updates API menu to include the new ISBN endpoint |
Files not reviewed (3)
- website/src/routes/api/(actions)/isbn/index.mdx: Language not supported
- website/src/routes/api/(schemas)/string/index.mdx: Language not supported
- website/src/routes/guides/(main-concepts)/pipelines/index.mdx: Language not supported
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
a -> an Signed-off-by: ysknsid25 <[email protected]>
|
Great idea! Thank you for creating this PR! I will try to review it next week! |
commit: |
Signed-off-by: ysknsid25 <[email protected]>
|
Sorry for the delay. I will get back to this PR as soon as possible. |
|
no problem. take it easy 👍 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Signed-off-by: ysknsid25 <[email protected]>
|
I fixed copilot's pointing out 👍 |
|
@fabian-hiller is attempting to deploy a commit to the Valibot Team on Vercel. A member of the Team first needs to authorize it. |
|
I changed the code to allow spaces instead of hyphens. I also refactored the checksum functions. I believe they are mathematically equivalent, but please let me know if you disagree. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 36 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
v1.2.0 is available |
2 participants
I am a certified librarian. So I realized that I would like to be able to verify ISBNs when registering books.
The ISBN specifications are here.