From 1a03677d0338f1d1f930a9d6e5e6c60daa0a9a83 Mon Sep 17 00:00:00 2001 From: Eero Tamminen Date: Wed, 5 Mar 2025 16:58:09 +0200 Subject: [PATCH 1/2] Change app dashboard menu to use pending requests metric Instead of first token latency, as that will be available only for queries using streaming mode. Signed-off-by: Eero Tamminen --- .../common/dashboard/templates/configmap-metrics.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/helm-charts/common/dashboard/templates/configmap-metrics.yaml b/helm-charts/common/dashboard/templates/configmap-metrics.yaml index 9bf7edaa3..3c207f1ad 100644 --- a/helm-charts/common/dashboard/templates/configmap-metrics.yaml +++ b/helm-charts/common/dashboard/templates/configmap-metrics.yaml @@ -2005,7 +2005,7 @@ data: "type": "prometheus", "uid": "${Metrics}" }, - "definition": "label_values(megaservice_first_token_latency_count,namespace)", + "definition": "label_values(megaservice_request_pending,namespace)", "hide": 0, "includeAll": false, "label": "Namespace", @@ -2014,7 +2014,7 @@ data: "options": [], "query": { "qryType": 1, - "query": "label_values(megaservice_first_token_latency_count,namespace)", + "query": "label_values(megaservice_request_pending,namespace)", "refId": "PrometheusVariableQueryEditor-VariableQuery" }, "refresh": 2, @@ -2033,7 +2033,7 @@ data: "type": "prometheus", "uid": "${Metrics}" }, - "definition": "label_values(megaservice_first_token_latency_count{namespace=\"$namespace\", service!~\".*-uservice\", service!~\".*-usvc\"},service)", + "definition": "label_values(megaservice_request_pending{namespace=\"$namespace\", service!~\".*-uservice\", service!~\".*-usvc\"},service)", "description": "Helm release name used as prefix for the services", "hide": 0, "includeAll": false, @@ -2043,7 +2043,7 @@ data: "options": [], "query": { "qryType": 1, - "query": "label_values(megaservice_first_token_latency_count{namespace=\"$namespace\", service!~\".*-uservice\", service!~\".*-usvc\"},service)", + "query": "label_values(megaservice_request_pending{namespace=\"$namespace\", service!~\".*-uservice\", service!~\".*-usvc\"},service)", "refId": "PrometheusVariableQueryEditor-VariableQuery" }, "refresh": 2, From 04f9dc878f721249a3564b3b715c11a68a0de569 Mon Sep 17 00:00:00 2001 From: Eero Tamminen Date: Wed, 5 Mar 2025 18:52:01 +0200 Subject: [PATCH 2/2] Update app dashboard units and set refresh rate Use more specific req/s + t/s (instead of count/s) for units. Signed-off-by: Eero Tamminen --- .../common/dashboard/templates/configmap-metrics.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/helm-charts/common/dashboard/templates/configmap-metrics.yaml b/helm-charts/common/dashboard/templates/configmap-metrics.yaml index 3c207f1ad..081da18bd 100644 --- a/helm-charts/common/dashboard/templates/configmap-metrics.yaml +++ b/helm-charts/common/dashboard/templates/configmap-metrics.yaml @@ -111,7 +111,7 @@ data: } ] }, - "unit": "cps" + "unit": "reqps" }, "overrides": [] }, @@ -640,7 +640,7 @@ data: } ] }, - "unit": "cps" + "unit": "t/s" }, "overrides": [] }, @@ -1091,7 +1091,7 @@ data: } ] }, - "unit": "cps" + "unit": "t/s" }, "overrides": [] }, @@ -1970,7 +1970,7 @@ data: "type": "timeseries" } ], - "refresh": false, + "refresh": "30s", "schemaVersion": 38, "tags": [], "templating": {