Skip to content

Conversation

@dhyaniarun1993
Copy link
Collaborator

@dhyaniarun1993 dhyaniarun1993 commented Sep 30, 2025

Closes #179

@dhyaniarun1993 dhyaniarun1993 self-assigned this Sep 30, 2025
@dhyaniarun1993 dhyaniarun1993 added the A-ci Area: CI label Sep 30, 2025
@wiz-f93cfcf63e
Copy link

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Total -

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@emhane
Copy link
Member

emhane commented Oct 7, 2025

pls reference the issue which this closes in pr description, there is an issue for fixing ci runners.

any lint fixes that are a result of upgrading reth rust version makes more sense to fix upstream and then pull those changes from upstream

@dhyaniarun1993
Copy link
Collaborator Author

clippy issue will be resolved once paradigmxyz#18900 is merged

@dhyaniarun1993 dhyaniarun1993 linked an issue Oct 9, 2025 that may be closed by this pull request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems out of scope of this pr

@dhyaniarun1993 dhyaniarun1993 marked this pull request as ready for review October 9, 2025 13:32
Copilot AI review requested due to automatic review settings October 9, 2025 13:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates GitHub Actions workflow configurations to fix CI runners by migrating from custom "Reth" runner groups to standard ubuntu-latest runners and updating repository references from paradigmxyz/reth to op-rs/op-reth.

  • Replaced all custom runner group configurations with ubuntu-latest
  • Updated repository condition checks to reference the new op-rs/op-reth repository
  • Standardized runner configurations across all workflow files

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/unit.yml Replaced Reth runner group with ubuntu-latest for test, state, and doc jobs
.github/workflows/sync.yml Updated sync job to use ubuntu-latest runner
.github/workflows/sync-era.yml Updated sync job to use ubuntu-latest runner
.github/workflows/stage.yml Updated stage-run-test job to use ubuntu-latest runner
.github/workflows/prepare-reth.yml Updated repository check and runner configuration
.github/workflows/kurtosis.yml Updated test and notification jobs to use ubuntu-latest runners
.github/workflows/kurtosis-op.yml Updated test and notification jobs to use ubuntu-latest runners
.github/workflows/integration.yml Updated test job to use ubuntu-latest runner
.github/workflows/hive.yml Updated repository check and all jobs to use ubuntu-latest runners
.github/workflows/e2e.yml Updated e2e-testsuite job to use ubuntu-latest runner
.github/workflows/compact.yml Updated compact-codec job to use ubuntu-latest runner
.github/workflows/bench.yml Updated codspeed job to use ubuntu-latest runner

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@emhane
Copy link
Member

emhane commented Oct 9, 2025

lint referes to [main] branch, it should be [unstable]

@dhyaniarun1993 dhyaniarun1993 requested a review from Copilot October 9, 2025 13:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@emhane emhane merged commit 799f8ae into unstable Oct 9, 2025
41 of 42 checks passed
@emhane emhane deleted the arun/fix/ci-runner branch October 9, 2025 13:42
emhane pushed a commit that referenced this pull request Oct 20, 2025
Closes #179

---------

Co-authored-by: Julian Meyer <[email protected]>
meyer9 added a commit that referenced this pull request Oct 31, 2025
Closes #179

---------

Co-authored-by: Julian Meyer <[email protected]>
emhane pushed a commit that referenced this pull request Nov 11, 2025
Closes #179

---------

Co-authored-by: Julian Meyer <[email protected]>
meyer9 added a commit that referenced this pull request Nov 13, 2025
Closes #179

---------

Co-authored-by: Julian Meyer <[email protected]>
emhane pushed a commit that referenced this pull request Nov 18, 2025
Closes #179

---------

Co-authored-by: Julian Meyer <[email protected]>
emhane pushed a commit that referenced this pull request Nov 25, 2025
Closes #179

---------

Co-authored-by: Julian Meyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Area: CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Point workflows to GitHub runners

4 participants