Merge pull request #181 from ryan-rowland/Add_RegisterContext_CloseWithHeaders

Added RegisterContext.closeHeaders logic

Author: wakamoleguy

src/RegisterContext.js

@@ -51,6 +51,10 @@ RegisterContext.prototype = {
     extraHeaders.push('Contact: ' + this.contact + ';expires=' + this.expires);
     extraHeaders.push('Allow: ' + SIP.Utils.getAllowedMethods(this.ua));
 
+    // Save original extraHeaders to be used in .close
+    this.closeHeaders = options.closeWithHeaders ?
+      (this.options.extraHeaders || []).slice() : [];
+
     this.receiveResponse = function(response) {
       var contact, expires,
         contacts = response.getHeaders('contact').length,
@@ -191,8 +195,13 @@ RegisterContext.prototype = {
   },
 
   close: function() {
+    var options = {
+      all: false,
+      extraHeaders: this.closeHeaders
+    };
+
     this.registered_before = this.registered;
-    this.unregister();
+    this.unregister(options);
   },
 
   unregister: function(options) {

test/spec/SpecRegisterContext.js

@@ -73,6 +73,14 @@ describe('RegisterContext', function() {
       RegisterContext.register(options);
       expect(RegisterContext.send).toHaveBeenCalled();
     });
+
+    it('sets its closeHeaders property if options.closeWithHeaders flag is true', function() {
+      RegisterContext.register({
+        closeWithHeaders: true,
+        extraHeaders: [ 'X-Foo: foo', 'X-Bar: bar' ]
+      });
+      expect(RegisterContext.closeHeaders.length).toBe(2);
+    });
   });
 
   describe('.registrationFailure', function() {
@@ -153,16 +161,25 @@ describe('RegisterContext', function() {
     beforeEach(function(){
       spyOn(RegisterContext, 'unregister').and.returnValue('unregister');
     });
-    it('takes registered and move it to registerd_before', function() {
+
+    it('takes registered and move it to registered_before', function() {
       expect(RegisterContext.registered).not.toBe(RegisterContext.registered_before); 
       RegisterContext.close();
       expect(RegisterContext.registered).toBe(RegisterContext.registered_before);
     });
 
-    it('calls unregister', function() {
+    it('calls unregister with closeHeaders', function() {
+      jasmine.addCustomEqualityTester(function objectEquality(a, b) {
+        return a === b || JSON.stringify(a) === JSON.stringify(b);
+      });
+
       expect(RegisterContext.unregister).not.toHaveBeenCalled();
+
+      RegisterContext.closeHeaders = [ 'X-Foo: foo' ,'X-Bar: bar' ];
+      var mockArgs = { all: false, extraHeaders: RegisterContext.closeHeaders };
+
       RegisterContext.close();
-      expect(RegisterContext.unregister).toHaveBeenCalledWith();
+      expect(RegisterContext.unregister).toHaveBeenCalledWith(mockArgs);
     });
   });