Skip to content

Commit ab5eb31

Browse files
author
James Criscuolo
committed
Merge branch 'master' into release
2 parents d408104 + 53d3307 commit ab5eb31

20 files changed

+85
-310
lines changed

demo/demo-2.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,10 @@ const bob = buildUser(
5757
videoRemoteBob
5858
);
5959

60+
if (!alice || !bob) {
61+
console.error("Something went wrong");
62+
}
63+
6064
function buildUser(
6165
webSocketServer: string,
6266
aor: string,

demo/demo-3.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,10 @@ const bob = buildUser(
154154
receiveBob
155155
);
156156

157+
if (!alice || !bob) {
158+
console.error("Something went wrong");
159+
}
160+
157161
function buildUser(
158162
webSocketServer: string,
159163
aor: string,

docs/api/sip.js.sessiondescriptionhandler.holdmodifier.md

Lines changed: 0 additions & 26 deletions
This file was deleted.

docs/api/sip.js.sessiondescriptionhandler.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ export interface SessionDescriptionHandler
1919
| [close()](./sip.js.sessiondescriptionhandler.close.md) | Destructor. |
2020
| [getDescription(options, modifiers)](./sip.js.sessiondescriptionhandler.getdescription.md) | Gets the local description from the underlying media implementation. |
2121
| [hasDescription(contentType)](./sip.js.sessiondescriptionhandler.hasdescription.md) | Returns true if the Session Description Handler can handle the Content-Type described by a SIP message. |
22-
| [holdModifier(sessionDescription)](./sip.js.sessiondescriptionhandler.holdmodifier.md) | The modifier that should be used when the session would like to place the call on hold. |
2322
| [rollbackDescription()](./sip.js.sessiondescriptionhandler.rollbackdescription.md) | Rolls back the current local/remote offer to the prior stable state. |
2423
| [sendDtmf(tones, options)](./sip.js.sessiondescriptionhandler.senddtmf.md) | Send DTMF via RTP (RFC 4733). Returns true if DTMF send is successful, false otherwise. |
2524
| [setDescription(sdp, options, modifiers)](./sip.js.sessiondescriptionhandler.setdescription.md) | Sets the remote description to the underlying media implementation. |

docs/session-description-handler/sip.js.sessiondescriptionhandler.holdmodifier.md

Lines changed: 0 additions & 24 deletions
This file was deleted.

docs/session-description-handler/sip.js.sessiondescriptionhandler.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ It is expected/intended to be extended by specific WebRTC based applications.
5252
| [getLocalMediaStream(options)](./sip.js.sessiondescriptionhandler.getlocalmediastream.md) | | Get a media stream from the media stream factory and set the local media stream. |
5353
| [getLocalSessionDescription()](./sip.js.sessiondescriptionhandler.getlocalsessiondescription.md) | | Gets the peer connection's local session description. |
5454
| [hasDescription(contentType)](./sip.js.sessiondescriptionhandler.hasdescription.md) | | Returns true if the SessionDescriptionHandler can handle the Content-Type described by a SIP message. |
55-
| [holdModifier(sessionDescription)](./sip.js.sessiondescriptionhandler.holdmodifier.md) | | The modifier that should be used when the session would like to place the call on hold. |
5655
| [iceGatheringComplete()](./sip.js.sessiondescriptionhandler.icegatheringcomplete.md) | | Called when ICE gathering completes and resolves any waiting promise. |
5756
| [sendDtmf(tones, options)](./sip.js.sessiondescriptionhandler.senddtmf.md) | | Send DTMF via RTP (RFC 4733). Returns true if DTMF send is successful, false otherwise. |
5857
| [setDescription(sdp, options, modifiers)](./sip.js.sessiondescriptionhandler.setdescription.md) | | Sets an offer or answer. |

etc/api/sip.js.api.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,6 @@ export interface SessionDescriptionHandler {
532532
close(): void;
533533
getDescription(options?: SessionDescriptionHandlerOptions, modifiers?: Array<SessionDescriptionHandlerModifier>): Promise<BodyAndContentType>;
534534
hasDescription(contentType: string): boolean;
535-
holdModifier(sessionDescription: RTCSessionDescriptionInit): Promise<RTCSessionDescriptionInit>;
536535
rollbackDescription?(): Promise<void>;
537536
sendDtmf(tones: string, options?: unknown): boolean;
538537
setDescription(sdp: string, options?: SessionDescriptionHandlerOptions, modifiers?: Array<SessionDescriptionHandlerModifier>): Promise<void>;

etc/session-description-handler/sip.js.api.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ export class SessionDescriptionHandler implements SessionDescriptionHandler_2 {
4747
protected getLocalMediaStream(options?: SessionDescriptionHandlerOptions): Promise<void>;
4848
protected getLocalSessionDescription(): Promise<RTCSessionDescription>;
4949
hasDescription(contentType: string): boolean;
50-
holdModifier(sessionDescription: RTCSessionDescriptionInit): Promise<RTCSessionDescriptionInit>;
5150
protected iceGatheringComplete(): void;
5251
get localMediaStream(): MediaStream;
5352
protected _localMediaStream: MediaStream;

0 commit comments

Comments
 (0)