fix: service.stop() callback should be async #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

gmaclennan wants to merge 1 commit into onlxltd:master from gmaclennan:patch-4

gmaclennan commented Sep 4, 2023

Don't release the zalgo


          fix: service.stop() callback should be async

d723e9b

Don't [release the zalgo](https://blog.izs.me/2013/08/designing-apis-for-asynchrony/)

Member

mdidon commented Oct 11, 2023

Included in PR #44

mdidon closed this

mdidon mentioned this pull request

Version 1.2.0 #44

Merged

This was referenced Sep 13, 2024

[Snyk] Upgrade: , , , , , , , bonjour-service, chokidar, express, html-entities, ipaddr.js, launch-editor, schema-utils, selfsigned, webpack, webpack-dev-middleware, ws X-oss-byte/webpack-dev-server#118

Open

[Snyk] Upgrade: , , , , , , , bonjour-service, chokidar, express, html-entities, ipaddr.js, launch-editor, schema-utils, selfsigned, webpack, webpack-dev-middleware, ws X-oss-byte/webpack-dev-server#119

Open

[Snyk] Upgrade: , , , , , , , bonjour-service, chokidar, express, html-entities, ipaddr.js, launch-editor, schema-utils, selfsigned, webpack, webpack-dev-middleware, ws X-oss-byte/webpack-dev-server#120

Open

[Snyk] Upgrade: , , , , , , , bonjour-service, chokidar, express, html-entities, ipaddr.js, launch-editor, schema-utils, selfsigned, webpack, webpack-dev-middleware, ws X-oss-byte/webpack-dev-server#121

Open

[Snyk] Upgrade: , , , , , , , bonjour-service, chokidar, express, html-entities, ipaddr.js, launch-editor, schema-utils, selfsigned, webpack, webpack-dev-middleware, ws X-oss-byte/webpack-dev-server#122

Open

This was referenced Sep 20, 2024

[Snyk] Upgrade: , , , , , , , bonjour-service, chokidar, express, html-entities, ipaddr.js, launch-editor, schema-utils, selfsigned, webpack, webpack-dev-middleware, ws X-oss-byte/webpack-dev-server#123

Open

[Snyk] Upgrade: , , , , , , , bonjour-service, chokidar, express, html-entities, ipaddr.js, launch-editor, schema-utils, selfsigned, webpack, webpack-dev-middleware, ws X-oss-byte/webpack-dev-server#124

Open

[Snyk] Upgrade: , , , , , , , bonjour-service, chokidar, express, html-entities, ipaddr.js, launch-editor, schema-utils, selfsigned, webpack, webpack-dev-middleware, ws X-oss-byte/webpack-dev-server#125

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet