feat: replace parameter namespace values with runtime value #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the runtime value
rushtehrani
reviewed
Jan 10, 2021
| // Strip out whitespace from parameter value | ||
| formattedValue := strings.Replace(*param.Value, " ", "", -1) | ||
| *param.Value = strings.Replace(formattedValue, "{{workflow.namespace}}", namespace, -1) | ||
| *param.Value = strings.Replace(*param.Value, "{{workspace.namespace}}", namespace, -1) |
Contributor
There was a problem hiding this comment.
should this use formattedValue too?
Contributor
Author
There was a problem hiding this comment.
@rushtehrani Do you mean the 3rd line there?
*param.Value = strings.Replace(*param.Value, "{{workspace.namespace}}", namespace, -1)
If so, no. It is correct because we replace workflow.namespace above. If we set it to formattedValue we would clear out those changes.
Contributor
There was a problem hiding this comment.
Ah got it. Minor: might be cleaner to use ReplaceAll - it calls Replace with -1 internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #828
Special notes for your reviewer:
Checklist
Please check if applies
Required