Skip to content

fix: rename LogIn request to GetAccessToken #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2020
Merged

fix: rename LogIn request to GetAccessToken #705

merged 2 commits into from
Nov 3, 2020

Conversation

@Vafilor
Copy link
Contributor

@Vafilor Vafilor commented Nov 3, 2020

What this PR does:

Renames LogIn request to GetAccessToken to be more descriptive

Which issue(s) this PR fixes:

Fixes onepanelio/core#

Special notes for your reviewer:

Checklist

Please check if applies

  • I have added/updated relevant unit tests
  • I have added/updated relevant documentation

Required

  • I accept to release these changes under the Apache 2.0 License

@Vafilor Vafilor added this to the v0.15.0 milestone Nov 3, 2020
@Vafilor Vafilor self-assigned this Nov 3, 2020
@Vafilor Vafilor merged commit 74bc140 into onepanelio:master Nov 3, 2020
@Vafilor Vafilor deleted the fix/rename.auth branch November 3, 2020 21:45
@rushtehrani
Copy link
Contributor

rushtehrani commented Nov 6, 2020

Facing multiple issues with this change:

  • Logged in as a non-admin user, there are buttons that I had access to before that are missing. For example "Workspace Templates" and "Workflow Templates"
  • CVAT is now not able to log in since it uses the old is_valid_token API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Vafilor Vafilor

Labels

None yet

Projects

None yet

Milestone

v0.15.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Vafilor @rushtehrani