fix: Set TENSORBOARD_PROXY_URL so TensorBoard can easily be used in JupyterLab #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushtehrani
changed the title
rushtehrani
force-pushed
the
fix/tensorboard
branch
from
30e64d9 to
a598b3f
Compare
rushtehrani
changed the title
rushtehrani
changed the title
rushtehrani
commented
Nov 2, 2020
| // These hooks will attempt to persist conda, pip, and jupyterlab extensions between pause and shut-down. | ||
| func Up20201031165106(tx *sql.Tx) error { | ||
| // This code is executed when the migration is applied. | ||
| return updateWorkspaceTemplateManifest("20201031165106_jupyterlab.yaml", jupyterLabTemplateName) |
Contributor
Author
There was a problem hiding this comment.
@aleksandrmelnikov @Vafilor I think for the YAML name, we should have the timestamp first so things are ordered in the IDE accordingly. Thoughts?
rushtehrani
commented
Nov 2, 2020
| // Down20201031165106 removes the lifecycle hooks from the template. | ||
| func Down20201031165106(tx *sql.Tx) error { | ||
| // This code is executed when the migration is rolled back. | ||
| return updateWorkspaceTemplateManifest("20201028145442_jupyterlab.yaml", jupyterLabTemplateName) |
Contributor
Author
There was a problem hiding this comment.
@aleksandrmelnikov @Vafilor When doing down migrations, I'm proposing we use the previous YAML here. Thoughts, issues?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This allows TensorBoard to be used in Onepanel's JupyterLab Workspaces.
Special notes for your reviewer:
Example usage in JupyterLab:
Checklist
Please check if applies
Required