feat: Adding "parameters" to workflow template API response. #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 27, 2020 12:07
- Using specific function to achieve same functionality
Removing the for-loop because it caused duplicate values.
Wrong:
```json
"parameters": [
{
"type": null,
"required": null,
"name": "source",
"options": null,
"hint": null,
"value": "name: command\norder: 1\nvalue: python mnist/main.py --epochs=5\n",
"display_name": null
},
{
"type": null,
"required": null,
"name": "command",
"options": null,
"hint": null,
"value": "name: command\norder: 1\nvalue: python mnist/main.py --epochs=5\n",
"display_name": null
}
```
Right:
```json
"parameters": [
{
"options": [],
"name": "source",
"value": "https://github.com/onepanelio/tensorflow-examples.git",
"type": "",
"displayName": "",
"hint": "",
"required": false
},
{
"options": [],
"name": "command",
"value": "python mnist/main.py --epochs=5",
"type": "",
"displayName": "",
"hint": "",
"required": false
}
```
ListWorkflowTemplateVersions.
and generate the "parameters" column values for each.
loaded from the database.
Adding code to paginate through results.
- Results may be less than pageSize. Changed to paginate only if there are over 0 results.
- So we can load the JSONB data from the database.
- Instead, retrieving the WorkflowTemplateVersion from the database, and using it's params for the WorkflowTemplate's
- Otherwise, templates are not found consistently.
- This ensures the transaction commits.
not require a namespace filter.
database without filtering.
- Directly retrieving all the WorkflowTemplateVersions from the database and updating them, instead of going through namespaces, workflow templates, then the versions.
added 9 commits
July 29, 2020 11:19
Simplifying the returned err.
- Do not expose DB functions.
- This can happen when editing a workflow template in the UI and hitting save.
Vafilor
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes onepanelio/core# #387
Special notes for your reviewer: