Skip to content

Conversation

@Vafilor
Copy link
Contributor

@Vafilor Vafilor commented Jul 29, 2020

What this PR does:

Adds support to filter workflow templates by a label.

Which issue(s) this PR fixes:

Fixes #434

Special notes for your reviewer:

The label is provided as a query parameter.

Sample

/apis/v1beta1/andrey/workflow_templates?labels=key=key,value=lime

Testing Checklist

  • Migration on existing cluster and new cluster
  • Backwards compatibility for listing workflow templates (can test this on an existing cluster)
  • Filtering works (multiple responses for a key/value, single response, and no response for none existing)

@aleksandrmelnikov aleksandrmelnikov merged commit b239ca1 into dev Jul 29, 2020
@aleksandrmelnikov aleksandrmelnikov deleted the feat/onepanelio.core.434-filter.workflow.templates.by.label branch July 29, 2020 21:15
@Vafilor Vafilor added this to the v0.12.0 milestone Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants