feat: Centralize authorization to one endpoint #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e IsAuthorized endpoint
…oming to structure. * Auth token will always be present unless you are validating an auth token.
…D binding didn't work. Also updated the request to get data from headers if nothing is in body.
…orized.changes' into feat/onepanelio.core.266-is.authorized.changes
…orized.changes' into feat/authorization.updates
rushtehrani
reviewed
Jun 11, 2020
pkg/config.go
Outdated
| namespace := "onepanel" | ||
| configMap, err := c.getConfigMap(namespace, "onepanel") | ||
| if err != nil { | ||
| configMap, configMapErr := c.getConfigMap(namespace, "onepanel") |
There was a problem hiding this comment.
Originally I got an err shadowed compilation error.
But I'm not getting it now - pushing up a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Removes the authorization endpoint for workspaces and puts that logic into the single IsAuthorized endpoint.
Which issue(s) this PR fixes:
Fixes #266
Special notes for your reviewer:
Also see the Manifests PR that removes fqdn from headers.