Skip to content

Conversation

@Vafilor
Copy link
Contributor

@Vafilor Vafilor commented Jun 5, 2020

What this PR does:

  • Fixed issue where login was not redirecting to the referer
  • Fixed issue where Token in login UI was cut off when it was a label over the input
  • Updated login button indicate loading (when network request is being made)

Which issue(s) this PR fixes:

Fixes onepanelio/onepanel#334

Special notes for your reviewer:

* Fixed issue where login was not redirecting to the referer
* Fixed issue where Token in login UI was cut off when it was a label over the input
* Updated login button indicate loading
@rushtehrani
Copy link
Contributor

@Vafilor just tried this and I'm not able to login at all. Steps to reproduce:

  • Log out
  • Enter a workspace URL
  • Try to log in

@rushtehrani rushtehrani added this to the v0.11.0 milestone Jun 6, 2020
@rushtehrani rushtehrani merged commit fa3cc66 into dev Jun 6, 2020
@rushtehrani rushtehrani deleted the fix/onepanel.core.334-login.redirect branch June 6, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants