AP-5718 # Fixed nested forms with no value breaking conditional logic

Author: mymattcarroll

CHANGELOG.md

@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 - `fileUploadService.restrictedFileTypes`
 
+### Fixed
+
+- nested forms with no value breaking conditional logic
+
 ## [8.8.1] - 2025-09-15
 
 ### Changed

src/conditionalLogicService/conditionallyShowOption.ts

@@ -12,10 +12,10 @@ export type ShouldShowOption =
 
 const handleAttributePredicate = (
   predicate: FormTypes.ChoiceElementOptionAttribute,
-  model: SubmissionTypes.S3SubmissionData['submission'],
+  model: SubmissionTypes.S3SubmissionData['submission'] | undefined,
   predicateElement: FormTypes.FormElementWithOptions,
 ) => {
-  const values = model[predicateElement.name]
+  const values = model?.[predicateElement.name]
   if (!values) return true
 
   if (
@@ -160,7 +160,7 @@ const isAttributeFilterValid = (
   }
 
   // verify that at least one option is selected
-  const values = formElementsCtrl.model[predicateElement.name]
+  const values = formElementsCtrl.model?.[predicateElement.name]
   if (!values) return false
   // if the model value is an array, verify that it has a selection
   if (

src/conditionalLogicService/evaluateConditionalPredicate.ts

@@ -1,4 +1,4 @@
-import { FormTypes, ConditionTypes } from '@oneblink/types'
+import { FormTypes, ConditionTypes, SubmissionTypes } from '@oneblink/types'
 import { FormElementsCtrl } from './types'
 import { typeCastService, formElementsService } from '..'
 import evaluateConditionalOptionsPredicate from './evaluateConditionalOptionsPredicate'
@@ -27,7 +27,7 @@ function getElementAndValue(
     if (formElementWithName) {
       return {
         formElementWithName,
-        value: formElementsCtrl.model[formElementWithName.name],
+        value: formElementsCtrl.model?.[formElementWithName.name],
       }
     }
   } else if (formElementsCtrl.parentFormElementsCtrl) {
@@ -154,9 +154,10 @@ export default function evaluateConditionalPredicate({
         ) {
           return
         }
-        const formModel = formElementsCtrl.model[predicateElement.name] as {
-          [name: string]: unknown
-        }
+        const formModel = formElementsCtrl.model?.[predicateElement.name] as
+          | SubmissionTypes.S3SubmissionData['submission']
+          | undefined
+
         const result = conditionallyShowByPredicate(
           {
             model: formModel,

src/conditionalLogicService/generateFormElementsConditionallyShown.ts

@@ -154,7 +154,7 @@ const generateFormElementsConditionallyShownWithParent = ({
           if (formElementsConditionallyShown[element.name]) {
             break
           }
-          const entries = formElementsCtrl.model[element.name] as
+          const entries = formElementsCtrl.model?.[element.name] as
             | Array<SubmissionTypes.S3SubmissionData['submission']>
             | undefined
           formElementsConditionallyShown[element.name] = {

src/conditionalLogicService/types.ts

@@ -1,7 +1,7 @@
 import { FormTypes, SubmissionTypes } from '@oneblink/types'
 
 export type FormElementsCtrl = {
-  model: SubmissionTypes.S3SubmissionData['submission']
+  model: SubmissionTypes.S3SubmissionData['submission'] | undefined
   flattenedElements: FormTypes.FormElement[]
   parentFormElementsCtrl?: FormElementsCtrl
 }