✨ Support Ruby 2.2 & 2.3

Author: pboling

.github/workflows/ancient.yml

@@ -35,8 +35,8 @@ jobs:
         gemfile:
           - ancient
         ruby:
-          - "2.3"
-          - "2.2"
+          - "2.3.8"
+          - "2.2.10"
     runs-on: ubuntu-20.04
     continue-on-error: ${{ matrix.experimental || endsWith(matrix.ruby, 'head') }}
     steps:

.tool-versions

@@ -1 +1 @@
-ruby 2.6.10
+ruby 2.3.8

gemfiles/ancient.gemfile

@@ -9,10 +9,8 @@ source "https://rubygems.org"
 # Exceptions, if any, will be found in gemfiles/*
 
 # Testing
-gem "rspec", "~> 3.12"                        # ruby *
-gem "rack-test", "~> 2.1"                     # ruby 2.0
-gem "rack", "< 3"                             # ruby < 2.4
-gem "json", "< 2.6"                           # ruby < 2.3
+gem "rack", "~> 2.1.4.3"                      # ruby 2.2.2
+gem "json", "~> 2.5.1"                        # ruby 2.0
 
 # Debugging
 eval_gemfile "contexts/debug.gemfile"

gemfiles/contexts/debug.gemfile

@@ -1,3 +1,6 @@
-if ENV['CI'].nil? && ENV.fetch('DEBUG', 'false').casecmp?('true')
+# Ancient rubies do not have String#casecmp?
+debugging = ENV['CI'].nil? && ENV.fetch('DEBUG', 'false')
+
+if debugging && debugging[/true/i]
   gem "byebug"
 end

gemfiles/contexts/testing.gemfile

@@ -1,6 +1,4 @@
 # Testing
-gem "rspec", "~> 3.12"                        # ruby *
-gem "rack-test", "~> 2.1"                     # ruby 2.0
 gem "rack", "~> 3.0", ">= 3.0.8"              # ruby 2.4
 gem "rack-session", "~> 2.0"                  # ruby 2.4
 gem "json", "~> 2.6", ">= 2.6.3"              # ruby 2.3

lib/omniauth/strategies/jwt.rb

@@ -53,7 +53,7 @@ def decoded
               {
                 algorithms: default_algos,
                 jwks: options.jwks_loader
-              }.compact
+              }.delete_if {|_, v| v.nil? }
             )
           )[0]
         rescue Exception => e

omniauth-jwt2.gemspec

@@ -20,6 +20,10 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
+  # TODO: Since this gem supports Ruby >= 2.2 we need to ensure no gems are
+  #       added here that require a newer version. Once this gem progresses to
+  #       only support non-EOL Rubies, all dependencies can be listed in this
+  #       gemspec, and the gemfiles/* pattern can be dispensed with.
   spec.add_dependency "jwt", "~> 2.2", ">= 2.2.1"                           # ruby 2.1
   spec.add_dependency "omniauth", ">= 1.1"                                  # ruby 2.2
 
@@ -30,4 +34,9 @@ Gem::Specification.new do |spec|
   # Hot reload
   spec.add_development_dependency "guard"                                   # ruby 1.9.3
   spec.add_development_dependency "guard-rspec"                             # ruby *
+
+  # Testing
+  spec.add_development_dependency "rspec", "~> 3.12"                        # ruby *
+  spec.add_development_dependency "rack-test", "~> 2.1"                     # ruby 2.0
+  spec.add_development_dependency "rspec-pending_for", "~> 0.1"             # ruby *
 end

spec/lib/omniauth/strategies/jwt_spec.rb

@@ -123,11 +123,12 @@
       'ES512' => 'secp521r1'
     }.freeze
 
-    {
+    algos =     {
       OpenSSL::PKey::RSA => %w[RS256 RS384 RS512],
-      OpenSSL::PKey::EC => %w[ES256 ES384 ES512],
       String => %w[HS256 HS384 HS512]
-    }.each do |private_key_class, algorithms|
+    }
+    algos.merge!(OpenSSL::PKey::EC => %w[ES256 ES384 ES512]) unless ['2.2.10', '2.3.8'].include?(RubyVersion.to_s)
+    algos.each do |private_key_class, algorithms|
       algorithms.each do |algorithm|
         context "when the #{algorithm} algorithm is used" do
           let(:algorithm) { algorithm }

spec/spec_helper.rb

@@ -2,6 +2,7 @@
 require 'securerandom'
 
 # 3rd party gems
+require 'rspec/pending_for'
 begin
   require 'rack/session'
 rescue LoadError