Skip to content

Union of dataclasses not discarding parameters on class change#833

Merged
mauvilsa merged 1 commit intomainfrom
issue-829-prev-class-path
Jan 22, 2026
Merged

Union of dataclasses not discarding parameters on class change#833
mauvilsa merged 1 commit intomainfrom
issue-829-prev-class-path

Conversation

@mauvilsa
Copy link
Member

What does this PR do?

Fixes #829

Before submitting

  • Did you read the contributing guideline?
  • [n/a] Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG including a pull request link? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added the bug Something isn't working label Jan 22, 2026
@sonarqubecloud
Copy link

@mauvilsa mauvilsa merged commit 260a2f2 into main Jan 22, 2026
29 checks passed
@mauvilsa mauvilsa deleted the issue-829-prev-class-path branch January 22, 2026 17:21
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (384a1ea) to head (d4b0fd9).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #833   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         7264      7267    +3     
=========================================
+ Hits          7264      7267    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fields being unions of dataclasses with defaults cannot be configured.

1 participant