fix: remove duplicate dataset_id parameter in append-rows endpoint

Author: stainless-app[bot]

.stats.yml

@@ -1,4 +1,4 @@
 configured_endpoints: 102
-openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/llamastack%2Fllama-stack-client-60d07d12e08e84edf3d1d8665182f45548d840821600ee994b7e4f32c40c1d49.yml
-openapi_spec_hash: 375be93b0b1348b7dac1a4749f806870
+openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/llamastack%2Fllama-stack-client-36a0290facb461859b027e5f50206ce9c05fc5d0e8366d1e210ade0bda556936.yml
+openapi_spec_hash: 7ca2a28f0cc0958f01709c749cc3b7a4
 config_hash: d1db834ac019b3bb2e260c9e37dcb5d1

api.md

@@ -522,7 +522,7 @@ Methods:
 
 - <code title="get /v1beta/datasets/{dataset_id}">client.beta.datasets.<a href="./src/llama_stack_client/resources/beta/datasets.py">retrieve</a>(dataset_id) -> <a href="./src/llama_stack_client/types/beta/dataset_retrieve_response.py">DatasetRetrieveResponse</a></code>
 - <code title="get /v1beta/datasets">client.beta.datasets.<a href="./src/llama_stack_client/resources/beta/datasets.py">list</a>() -> <a href="./src/llama_stack_client/types/beta/dataset_list_response.py">DatasetListResponse</a></code>
-- <code title="post /v1beta/datasetio/append-rows/{dataset_id}">client.beta.datasets.<a href="./src/llama_stack_client/resources/beta/datasets.py">appendrows</a>(path_dataset_id, \*\*<a href="src/llama_stack_client/types/beta/dataset_appendrows_params.py">params</a>) -> None</code>
+- <code title="post /v1beta/datasetio/append-rows/{dataset_id}">client.beta.datasets.<a href="./src/llama_stack_client/resources/beta/datasets.py">appendrows</a>(dataset_id, \*\*<a href="src/llama_stack_client/types/beta/dataset_appendrows_params.py">params</a>) -> None</code>
 - <code title="get /v1beta/datasetio/iterrows/{dataset_id}">client.beta.datasets.<a href="./src/llama_stack_client/resources/beta/datasets.py">iterrows</a>(dataset_id, \*\*<a href="src/llama_stack_client/types/beta/dataset_iterrows_params.py">params</a>) -> <a href="./src/llama_stack_client/types/beta/dataset_iterrows_response.py">DatasetIterrowsResponse</a></code>
 - <code title="post /v1beta/datasets">client.beta.datasets.<a href="./src/llama_stack_client/resources/beta/datasets.py">register</a>(\*\*<a href="src/llama_stack_client/types/beta/dataset_register_params.py">params</a>) -> <a href="./src/llama_stack_client/types/beta/dataset_register_response.py">DatasetRegisterResponse</a></code>
 - <code title="delete /v1beta/datasets/{dataset_id}">client.beta.datasets.<a href="./src/llama_stack_client/resources/beta/datasets.py">unregister</a>(dataset_id) -> None</code>

src/llama_stack_client/resources/beta/datasets.py

@@ -115,9 +115,8 @@ def list(
 
     def appendrows(
         self,
-        path_dataset_id: str,
+        dataset_id: str,
         *,
-        body_dataset_id: str,
         rows: Iterable[Dict[str, object]],
         # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
         # The extra values given here take precedence over values defined on the client or passed to this method.
@@ -130,9 +129,7 @@ def appendrows(
         Append rows to a dataset.
 
         Args:
-          path_dataset_id: The ID of the dataset to append the rows to.
-
-          body_dataset_id: The ID of the dataset to append the rows to.
+          dataset_id: The ID of the dataset to append the rows to.
 
           rows: The rows to append to the dataset.
 
@@ -144,18 +141,12 @@ def appendrows(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
-        if not path_dataset_id:
-            raise ValueError(f"Expected a non-empty value for `path_dataset_id` but received {path_dataset_id!r}")
+        if not dataset_id:
+            raise ValueError(f"Expected a non-empty value for `dataset_id` but received {dataset_id!r}")
         extra_headers = {"Accept": "*/*", **(extra_headers or {})}
         return self._post(
-            f"/v1beta/datasetio/append-rows/{path_dataset_id}",
-            body=maybe_transform(
-                {
-                    "body_dataset_id": body_dataset_id,
-                    "rows": rows,
-                },
-                dataset_appendrows_params.DatasetAppendrowsParams,
-            ),
+            f"/v1beta/datasetio/append-rows/{dataset_id}",
+            body=maybe_transform({"rows": rows}, dataset_appendrows_params.DatasetAppendrowsParams),
             options=make_request_options(
                 extra_headers=extra_headers, extra_query=extra_query, extra_body=extra_body, timeout=timeout
             ),
@@ -393,9 +384,8 @@ async def list(
 
     async def appendrows(
         self,
-        path_dataset_id: str,
+        dataset_id: str,
         *,
-        body_dataset_id: str,
         rows: Iterable[Dict[str, object]],
         # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
         # The extra values given here take precedence over values defined on the client or passed to this method.
@@ -408,9 +398,7 @@ async def appendrows(
         Append rows to a dataset.
 
         Args:
-          path_dataset_id: The ID of the dataset to append the rows to.
-
-          body_dataset_id: The ID of the dataset to append the rows to.
+          dataset_id: The ID of the dataset to append the rows to.
 
           rows: The rows to append to the dataset.
 
@@ -422,18 +410,12 @@ async def appendrows(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
-        if not path_dataset_id:
-            raise ValueError(f"Expected a non-empty value for `path_dataset_id` but received {path_dataset_id!r}")
+        if not dataset_id:
+            raise ValueError(f"Expected a non-empty value for `dataset_id` but received {dataset_id!r}")
         extra_headers = {"Accept": "*/*", **(extra_headers or {})}
         return await self._post(
-            f"/v1beta/datasetio/append-rows/{path_dataset_id}",
-            body=await async_maybe_transform(
-                {
-                    "body_dataset_id": body_dataset_id,
-                    "rows": rows,
-                },
-                dataset_appendrows_params.DatasetAppendrowsParams,
-            ),
+            f"/v1beta/datasetio/append-rows/{dataset_id}",
+            body=await async_maybe_transform({"rows": rows}, dataset_appendrows_params.DatasetAppendrowsParams),
             options=make_request_options(
                 extra_headers=extra_headers, extra_query=extra_query, extra_body=extra_body, timeout=timeout
             ),

src/llama_stack_client/types/beta/dataset_appendrows_params.py

@@ -9,16 +9,11 @@
 from __future__ import annotations
 
 from typing import Dict, Iterable
-from typing_extensions import Required, Annotated, TypedDict
-
-from ..._utils import PropertyInfo
+from typing_extensions import Required, TypedDict
 
 __all__ = ["DatasetAppendrowsParams"]
 
 
 class DatasetAppendrowsParams(TypedDict, total=False):
-    body_dataset_id: Required[Annotated[str, PropertyInfo(alias="dataset_id")]]
-    """The ID of the dataset to append the rows to."""
-
     rows: Required[Iterable[Dict[str, object]]]
     """The rows to append to the dataset."""

tests/api_resources/beta/test_datasets.py

@@ -96,17 +96,15 @@ def test_streaming_response_list(self, client: LlamaStackClient) -> None:
     @parametrize
     def test_method_appendrows(self, client: LlamaStackClient) -> None:
         dataset = client.beta.datasets.appendrows(
-            path_dataset_id="dataset_id",
-            body_dataset_id="dataset_id",
+            dataset_id="dataset_id",
             rows=[{"foo": "bar"}],
         )
         assert dataset is None
 
     @parametrize
     def test_raw_response_appendrows(self, client: LlamaStackClient) -> None:
         response = client.beta.datasets.with_raw_response.appendrows(
-            path_dataset_id="dataset_id",
-            body_dataset_id="dataset_id",
+            dataset_id="dataset_id",
             rows=[{"foo": "bar"}],
         )
 
@@ -118,8 +116,7 @@ def test_raw_response_appendrows(self, client: LlamaStackClient) -> None:
     @parametrize
     def test_streaming_response_appendrows(self, client: LlamaStackClient) -> None:
         with client.beta.datasets.with_streaming_response.appendrows(
-            path_dataset_id="dataset_id",
-            body_dataset_id="dataset_id",
+            dataset_id="dataset_id",
             rows=[{"foo": "bar"}],
         ) as response:
             assert not response.is_closed
@@ -132,10 +129,9 @@ def test_streaming_response_appendrows(self, client: LlamaStackClient) -> None:
 
     @parametrize
     def test_path_params_appendrows(self, client: LlamaStackClient) -> None:
-        with pytest.raises(ValueError, match=r"Expected a non-empty value for `path_dataset_id` but received ''"):
+        with pytest.raises(ValueError, match=r"Expected a non-empty value for `dataset_id` but received ''"):
             client.beta.datasets.with_raw_response.appendrows(
-                path_dataset_id="",
-                body_dataset_id="dataset_id",
+                dataset_id="",
                 rows=[{"foo": "bar"}],
             )
 
@@ -363,17 +359,15 @@ async def test_streaming_response_list(self, async_client: AsyncLlamaStackClient
     @parametrize
     async def test_method_appendrows(self, async_client: AsyncLlamaStackClient) -> None:
         dataset = await async_client.beta.datasets.appendrows(
-            path_dataset_id="dataset_id",
-            body_dataset_id="dataset_id",
+            dataset_id="dataset_id",
             rows=[{"foo": "bar"}],
         )
         assert dataset is None
 
     @parametrize
     async def test_raw_response_appendrows(self, async_client: AsyncLlamaStackClient) -> None:
         response = await async_client.beta.datasets.with_raw_response.appendrows(
-            path_dataset_id="dataset_id",
-            body_dataset_id="dataset_id",
+            dataset_id="dataset_id",
             rows=[{"foo": "bar"}],
         )
 
@@ -385,8 +379,7 @@ async def test_raw_response_appendrows(self, async_client: AsyncLlamaStackClient
     @parametrize
     async def test_streaming_response_appendrows(self, async_client: AsyncLlamaStackClient) -> None:
         async with async_client.beta.datasets.with_streaming_response.appendrows(
-            path_dataset_id="dataset_id",
-            body_dataset_id="dataset_id",
+            dataset_id="dataset_id",
             rows=[{"foo": "bar"}],
         ) as response:
             assert not response.is_closed
@@ -399,10 +392,9 @@ async def test_streaming_response_appendrows(self, async_client: AsyncLlamaStack
 
     @parametrize
     async def test_path_params_appendrows(self, async_client: AsyncLlamaStackClient) -> None:
-        with pytest.raises(ValueError, match=r"Expected a non-empty value for `path_dataset_id` but received ''"):
+        with pytest.raises(ValueError, match=r"Expected a non-empty value for `dataset_id` but received ''"):
             await async_client.beta.datasets.with_raw_response.appendrows(
-                path_dataset_id="",
-                body_dataset_id="dataset_id",
+                dataset_id="",
                 rows=[{"foo": "bar"}],
             )