From 54b648dc74af3ecdf1a7df2305e8af379d8f17d2 Mon Sep 17 00:00:00 2001 From: wolfy1339 Date: Thu, 7 Jul 2022 11:41:04 -0400 Subject: [PATCH 1/5] fix: add `App` to the `type` property in the `ping` event ref: https://github.com/octokit/webhooks.net/pull/89 --- payload-schemas/api.github.com/ping/event.schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/payload-schemas/api.github.com/ping/event.schema.json b/payload-schemas/api.github.com/ping/event.schema.json index acec4ff09..86f242d1f 100644 --- a/payload-schemas/api.github.com/ping/event.schema.json +++ b/payload-schemas/api.github.com/ping/event.schema.json @@ -26,7 +26,7 @@ "deliveries_url" ], "properties": { - "type": { "type": "string", "enum": ["Repository", "Organization"] }, + "type": { "type": "string", "enum": ["Repository", "Organization", "App"] }, "id": { "type": "integer" }, "name": { "type": "string" }, "active": { "type": "boolean" }, From bb66917b2d99b5fac503656798cf65508c01ed37 Mon Sep 17 00:00:00 2001 From: wolfy1339 Date: Thu, 7 Jul 2022 11:42:10 -0400 Subject: [PATCH 2/5] fix: add `workflow_job` to `App` events https://github.com/octokit/webhooks.net/commit/020bf184902d94e3c704014e2f17addc77213f50 --- payload-schemas/api.github.com/common/app.schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/payload-schemas/api.github.com/common/app.schema.json b/payload-schemas/api.github.com/common/app.schema.json index 75c85d24c..d4b9cf29f 100644 --- a/payload-schemas/api.github.com/common/app.schema.json +++ b/payload-schemas/api.github.com/common/app.schema.json @@ -150,7 +150,8 @@ "team_add", "watch", "workflow_dispatch", - "workflow_run" + "workflow_run", + "workflow_job" ] } } From c02ba35dd96fa80cbd1e5bf97eb0a3292a19a911 Mon Sep 17 00:00:00 2001 From: wolfy1339 Date: Thu, 7 Jul 2022 11:42:24 -0400 Subject: [PATCH 3/5] build: generate types --- payload-types/schema.d.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/payload-types/schema.d.ts b/payload-types/schema.d.ts index fc3079973..2ab52f553 100644 --- a/payload-types/schema.d.ts +++ b/payload-types/schema.d.ts @@ -943,6 +943,7 @@ export interface App { | "watch" | "workflow_dispatch" | "workflow_run" + | "workflow_job" )[]; } export interface CheckRunCreatedEvent { @@ -4073,7 +4074,7 @@ export interface PingEvent { * The [webhook configuration](https://docs.github.com/en/rest/reference/repos#get-a-repository-webhook). */ hook: { - type: "Repository" | "Organization"; + type: "Repository" | "Organization" | "App"; id: number; name: string; active: boolean; From 6ab9871c11cf5109c03172f277112cb5b0484c6a Mon Sep 17 00:00:00 2001 From: wolfy1339 Date: Thu, 7 Jul 2022 11:49:00 -0400 Subject: [PATCH 4/5] fix: `merge_commit_sha` is not always `null` for `pull_request.opened` event --- payload-schemas/api.github.com/pull_request/opened.schema.json | 2 -- payload-types/schema.d.ts | 1 - 2 files changed, 3 deletions(-) diff --git a/payload-schemas/api.github.com/pull_request/opened.schema.json b/payload-schemas/api.github.com/pull_request/opened.schema.json index a8bc1ad65..e26a28c96 100644 --- a/payload-schemas/api.github.com/pull_request/opened.schema.json +++ b/payload-schemas/api.github.com/pull_request/opened.schema.json @@ -15,7 +15,6 @@ "state", "closed_at", "merged_at", - "merge_commit_sha", "active_lock_reason", "merged_by" ], @@ -23,7 +22,6 @@ "state": { "type": "string", "enum": ["open"] }, "closed_at": { "type": "null" }, "merged_at": { "type": "null" }, - "merge_commit_sha": { "type": "null" }, "active_lock_reason": { "type": "null" }, "merged_by": { "type": "null" } }, diff --git a/payload-types/schema.d.ts b/payload-types/schema.d.ts index 2ab52f553..0bd1a2476 100644 --- a/payload-types/schema.d.ts +++ b/payload-types/schema.d.ts @@ -4681,7 +4681,6 @@ export interface PullRequestOpenedEvent { state: "open"; closed_at: null; merged_at: null; - merge_commit_sha: null; active_lock_reason: null; merged_by: null; }; From 65a64bae311190ef2524a5aac6758ae9905f8dd0 Mon Sep 17 00:00:00 2001 From: wolfy1339 Date: Thu, 7 Jul 2022 11:53:23 -0400 Subject: [PATCH 5/5] style: run prettier --- payload-schemas/api.github.com/ping/event.schema.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/payload-schemas/api.github.com/ping/event.schema.json b/payload-schemas/api.github.com/ping/event.schema.json index 86f242d1f..467bff927 100644 --- a/payload-schemas/api.github.com/ping/event.schema.json +++ b/payload-schemas/api.github.com/ping/event.schema.json @@ -26,7 +26,10 @@ "deliveries_url" ], "properties": { - "type": { "type": "string", "enum": ["Repository", "Organization", "App"] }, + "type": { + "type": "string", + "enum": ["Repository", "Organization", "App"] + }, "id": { "type": "integer" }, "name": { "type": "string" }, "active": { "type": "boolean" },