Skip to content

fix: some datetime types should be nullable #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix: some datetime types should be nullable #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Octokit.Webhooks/Models/RepositoryRulesetEvent/RepositoryRuleset.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,10 @@ public sealed record RepositoryRuleset
public IReadOnlyCollection<Rule>? Rules { get; init; }

[JsonPropertyName("created_at")]
public string? CreatedAt { get; init; }
[JsonConverter(typeof(NullableDateTimeOffsetConverter))]
public DateTimeOffset? CreatedAt { get; init; }

[JsonPropertyName("updated_at")]
public string? UpdatedAt { get; init; }
[JsonConverter(typeof(NullableDateTimeOffsetConverter))]
public DateTimeOffset? UpdatedAt { get; init; }
}
7 changes: 4 additions & 3 deletions src/Octokit.Webhooks/Models/WorkflowJobEvent/WorkflowJob.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,12 @@ public sealed record WorkflowJob
public string? RunnerGroupName { get; init; }

[JsonPropertyName("started_at")]
[JsonConverter(typeof(DateTimeOffsetConverter))]
public DateTimeOffset StartedAt { get; init; }
[JsonConverter(typeof(NullableDateTimeOffsetConverter))]
public DateTimeOffset? StartedAt { get; init; }

[JsonPropertyName("completed_at")]
public string? CompletedAt { get; init; }
[JsonConverter(typeof(NullableDateTimeOffsetConverter))]
public DateTimeOffset? CompletedAt { get; init; }

[JsonPropertyName("workflow_name")]
public string? WorkflowName { get; init; }
Expand Down
4 changes: 2 additions & 2 deletions src/Octokit.Webhooks/Models/WorkflowJobEvent/WorkflowJobStep.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ public sealed record WorkflowJobStep
public long Number { get; init; }

[JsonPropertyName("started_at")]
[JsonConverter(typeof(DateTimeOffsetConverter))]
public DateTimeOffset StartedAt { get; init; }
[JsonConverter(typeof(NullableDateTimeOffsetConverter))]
public DateTimeOffset? StartedAt { get; init; }

[JsonPropertyName("completed_at")]
[JsonConverter(typeof(NullableDateTimeOffsetConverter))]
Expand Down