fix(retry): Retry requests after the x-ratelimit-reset time, not exactly at it. #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyasskin
changed the title
gr2m
reviewed
Oct 24, 2023
Contributor
gr2m
left a comment
gr2m
left a comment
There was a problem hiding this comment.
Fix looks good, can you update the tests accordingly?
Co-authored-by: Gregor Martynus <[email protected]>
Contributor
Author
|
I've adjusted the one test I found that seems to exercise this timing. |
gr2m
approved these changes
Oct 25, 2023
Contributor
gr2m
left a comment
gr2m
left a comment
There was a problem hiding this comment.
Great pull request, thank you 💐
Contributor
|
🎉 This PR is included in version 8.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #599, although it won't handle the case where the client and server actually have different times.