File tree Expand file tree Collapse file tree 1 file changed +5
-4
lines changed Expand file tree Collapse file tree 1 file changed +5
-4
lines changed Original file line number Diff line number Diff line change @@ -449,10 +449,11 @@ describe("GitHub API best practices", function () {
449449
450450 await Promise . all ( routes . map ( ( route ) => octokit . request ( `GET ${ route } ` ) ) ) ;
451451
452- // TODO: update @octokit /auth-app to cache/reuse an in-flight auth promise,
453- // so that only request is made. To that end, the assertion below doesn't
454- // check how many auth requests were made (currently 10), merely that there
455- // was at least one.
452+ // TODO: simplify this assertion if/when @octokit /auth-app improves its
453+ // behavior, see https://github.com/octokit/auth-app.js/issues/688
454+ // As it stands, it ends up making 10 auth requests (one for each top-level
455+ // request). But for the purposes of this test we don't actually care, we
456+ // just need to assert that at least one auth request was made.
456457 expect ( [ ...new Set ( requestLog ) ] . sort ( ) ) . toStrictEqual ( [
457458 "GET https://api.github.com/route01" ,
458459 "GET https://api.github.com/route02" ,
You can’t perform that action at this time.
0 commit comments