From c498d5111e1b79d4f3a848557b1649c6e950f20e Mon Sep 17 00:00:00 2001 From: Michael Lehto Date: Thu, 22 Feb 2024 08:27:51 +0100 Subject: [PATCH 1/3] Change "IssueId" to `long` --- Octokit.Tests.Integration/Clients/ProjectCardsClientTests.cs | 2 +- .../Reactive/ObservableProjectCardsClientTests.cs | 2 +- Octokit/Models/Response/Issue.cs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Octokit.Tests.Integration/Clients/ProjectCardsClientTests.cs b/Octokit.Tests.Integration/Clients/ProjectCardsClientTests.cs index 8607eb068f..e9d5b2384a 100644 --- a/Octokit.Tests.Integration/Clients/ProjectCardsClientTests.cs +++ b/Octokit.Tests.Integration/Clients/ProjectCardsClientTests.cs @@ -453,7 +453,7 @@ private static async Task CreateArchivedCardHelper(IGitHubClient gi return result; } - private static async Task CreateIssueCardHelper(IGitHubClient githubClient, int issueId, int columnId) + private static async Task CreateIssueCardHelper(IGitHubClient githubClient, long issueId, int columnId) { var newCard = new NewProjectCard(issueId, ProjectCardContentType.Issue); var result = await githubClient.Repository.Project.Card.Create(columnId, newCard); diff --git a/Octokit.Tests.Integration/Reactive/ObservableProjectCardsClientTests.cs b/Octokit.Tests.Integration/Reactive/ObservableProjectCardsClientTests.cs index 7eeb51957e..05369d95e0 100644 --- a/Octokit.Tests.Integration/Reactive/ObservableProjectCardsClientTests.cs +++ b/Octokit.Tests.Integration/Reactive/ObservableProjectCardsClientTests.cs @@ -441,7 +441,7 @@ private static async Task CreateArchivedCardHelper(IObservableGitHu return result; } - private static async Task CreateIssueCardHelper(IObservableGitHubClient githubClient, int issueId, int columnId) + private static async Task CreateIssueCardHelper(IObservableGitHubClient githubClient, long issueId, int columnId) { var newCard = new NewProjectCard(issueId, ProjectCardContentType.Issue); var result = await githubClient.Repository.Project.Card.Create(columnId, newCard); diff --git a/Octokit/Models/Response/Issue.cs b/Octokit/Models/Response/Issue.cs index b18e99c931..94f8c49460 100644 --- a/Octokit/Models/Response/Issue.cs +++ b/Octokit/Models/Response/Issue.cs @@ -45,7 +45,7 @@ public Issue(string url, string htmlUrl, string commentsUrl, string eventsUrl, i /// /// The internal Id for this issue (not the issue number) /// - public int Id { get; private set; } + public long Id { get; private set; } /// /// GraphQL Node Id From b1d53cc49bdaf560a71431113babaecc355308cb Mon Sep 17 00:00:00 2001 From: Michael Lehto Date: Thu, 22 Feb 2024 11:41:36 +0100 Subject: [PATCH 2/3] Change "Id" to `long` in ctor --- Octokit/Models/Response/Issue.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Octokit/Models/Response/Issue.cs b/Octokit/Models/Response/Issue.cs index 94f8c49460..b2fc9930be 100644 --- a/Octokit/Models/Response/Issue.cs +++ b/Octokit/Models/Response/Issue.cs @@ -12,7 +12,7 @@ public class Issue { public Issue() { } - public Issue(string url, string htmlUrl, string commentsUrl, string eventsUrl, int number, ItemState state, string title, string body, User closedBy, User user, IReadOnlyList