chore: improve perf of hot path #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
Can you describe the fix and the problem with text instead of just a picture next time. It would help with searchability and context in the future if this comes back up |
Contributor
Author
|
@wolfy1339 added some context |
wolfy1339
approved these changes
Nov 21, 2023
gr2m
reviewed
Nov 21, 2023
Contributor
gr2m
left a comment
gr2m
left a comment
There was a problem hiding this comment.
a chore: commit will not trigger a new release. Improving performance without changing behavior is a fix:
| console.warn = originalLogWarn; | ||
| console.error = originalLogError; | ||
|
|
||
| expect(calls).toStrictEqual(["warn", "error"]); |
Contributor
There was a problem hiding this comment.
you changed the nature of this test, can you please revert that? Please add a test where we log with all 4 methods
octokit.log.debug("foo");
octokit.log.info("bar");
octokit.log.warn("baz");
octokit.log.error("daz");
and check that only warn and error was logged
expect(calls).toStrictEqual(["warn", "error"]);
wolfy1339
pushed a commit
that referenced
this pull request
Nov 22, 2023
Contributor
|
🎉 This PR is included in version 5.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the hot path in core ;)
An investigation regarding the hotpaths showed that the console.warn and .error binding results take some time. Also a forEach call is Kind of hot.
To improve the performance console.warn and console.error are bound once at startup.
before
Resolves #ISSUE_NUMBER
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!