fix(sql-execute): the offset of the last sql goes wrong when it doesn't end with the delimiter#1970
Merged
Merged
Conversation
MarkPotato777
requested review from
PeachThinking,
yhilmare and
yizhouxw
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
The issue is that when we execute sqls in sql console. If the last sql does NOT end with the delimiter, the allocating of violating sql-check rules is not accurate.
The root reason is that the splitter will add the last sql in the buffer rather than directly add it into spliited sqls. Then the caller wrongly calculates the offset of the last sql.
The solution is that if there is a buffer after splitting, we obtain the buffer's index in the original sql.
Which issue(s) this PR fixes:
Fixes #1758
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: