fix: dune init project & root detection #5041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dune init project should assume the root is cwd if it's not set. Signed-off-by: Rudi Grinberg <[email protected]> ps-id: CF09BF37-DB27-43B9-9ED8-0DC40739106F
Member
Author
|
@snowleopard mind reviewing this? |
snowleopard
approved these changes
Oct 26, 2021
Collaborator
snowleopard
left a comment
snowleopard
left a comment
There was a problem hiding this comment.
The changes make sense but without a test it's hard to be sure this fixes the issue.
Member
Author
|
That's precisely why this is an issue in the first place unfortunately. We aren't able to write proper tests for this feature, because in test mode dune doesn't do any root directory inference :/ No wonder there's always bugs around this. |
Member
Author
|
I did verify it fixes the issue manually by the way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dune init project should assume the root is cwd if it's not set.