Fix #4799

Private libraries should be excluded from the package index

Signed-off-by: Rudi Grinberg <[email protected]>

Author: rgrinberg

CHANGES.md

@@ -1,6 +1,9 @@
 Unreleased
 ----------
 
+- Do not list private libraries in package listings (#4945, fixes #4799,
+  @rgrinberg)
+
 - Allow spaces in the directory argument of the `subdir` stanza (#4943, fixes
   #4907, @rgrinberg)
 

src/dune_rules/odoc.ml

@@ -603,7 +603,12 @@ let entry_modules_by_lib sctx lib =
   >>| Modules.entry_modules
 
 let entry_modules sctx ~pkg =
-  let l = libs_of_pkg sctx ~pkg in
+  let l =
+    libs_of_pkg sctx ~pkg
+    |> List.filter ~f:(fun lib ->
+           Lib.Local.info lib |> Lib_info.status |> Lib_info.Status.is_private
+           |> not)
+  in
   let+ l =
     Memo.Build.parallel_map l ~f:(fun l ->
         let+ m = entry_modules_by_lib sctx l in

test/blackbox-tests/test-cases/odoc/gh4799.t

@@ -15,6 +15,3 @@ Private libraries attached to packages shouldn't be displayed in the index
   $ dune build @doc
   $ cat _build/default/_doc/_mlds/foo/index.mld
   {0 foo index}
-  {1 Library foo}
-  The entry point of this library is the module:
-  {!module-Foo}.