Skip to content

Commit d7caeb9

Browse files
committed
fix: do not re-run jbuild syntax dune files on every run
While this is more correct, it ends up being too slow in practice especially since we don't have cut-off on the results Signed-off-by: Rudi Grinberg <[email protected]> <!-- ps-id: 9d1157e2-de9a-4b99-9bd5-3a76490d42d7 -->
1 parent 55ef357 commit d7caeb9

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGES.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
Unreleased
22
----------
33

4+
- Do not re-run jbuild syntax files on every iteration of the watch mode. This
5+
is too memory consuming. (#.., fix #6900, @rgrinberg)
6+
47
- Fix a crash when using a version of Coq < 8.13 due to the native compiler
58
config variable being missing. We now explicitly default to `(mode vo)` for
69
these older versions of Coq. (#7847, fixes #7846, @Alizter)

src/dune_rules/dune_load.ml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ module Script = struct
153153
in
154154
let ocaml = Action.Prog.ok_exn context.ocaml.ocaml in
155155
let* () =
156-
let* (_ : Memo.Run.t) = Memo.current_run () in
157156
Memo.of_reproducible_fiber
158157
(Process.run Strict ~display:Quiet ~dir:(Path.source dir)
159158
~env:context.env ocaml args)

0 commit comments

Comments
 (0)