Add proper error checking for duplicate stub usage

Signed-off-by: Rudi Grinberg <[email protected]>

Author: rgrinberg

src/c_sources.ml

@@ -109,5 +109,22 @@ let make (d : _ Dir_with_dune.t)
          in this directory"
         Lib_name.pp_quoted name
   in
+  let () =
+    let rev_map =
+      List.concat_map libs ~f:(fun (_, c_sources) ->
+        String.Map.values c_sources
+        |> List.map ~f:(fun (loc, source) ->
+          (C.Source.path source, loc)))
+      |> Path.Map.of_list
+    in
+    match rev_map with
+    | Ok _ -> ()
+    | Error (_, loc1, loc2) ->
+      Errors.fail loc2
+        "This c stub is already used in another stanza:@\n\
+         @[<v>%a@]@\n"
+        (Fmt.prefix (Fmt.string "- ") Loc.pp_file_colon_line)
+        loc1
+  in
   { libraries
   }

test/blackbox-tests/test-cases/duplicate-c-cxx/run.t

@@ -10,7 +10,10 @@ c_names and cxx_names with overlapping names in the same stanza
 c_names with overlapping names in different stanzas
   $ dune build --root diff-stanza @all
   Entering directory 'diff-stanza'
-  Multiple rules generated for _build/default/foo$ext_obj:
-  - dune:9
+  File "dune", line 9, characters 10-13:
+  9 |  (c_names foo))
+                ^^^
+  Error: This c stub is already used in another stanza:
   - dune:4
+  
   [1]