refactor: stricter Expo compatibility checks #1750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnf
reviewed
Jun 14, 2025
| loadAsync: (fontFamilyAlias: string, fileUri: string) => Promise<void>; | ||
| }; | ||
| ExpoAsset?: ExpoAssetModule; | ||
| ExpoFontLoader?: ExpoFontLoaderModule; |
Collaborator
There was a problem hiding this comment.
Should both of these be optional? I get a typescript error
Collaborator
Author
There was a problem hiding this comment.
The "types" check in CI is passing. So I believe this is correct as it is.
Collaborator
|
@vonovak Apologies for the delay. One comment on a typescript error the fotawesome issue should be gone now. Was a bad commit by me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
This PR increases strictness of checks of expo modules upon the
globalThis.expo.Also, it removes deep import of
react-native/Libraries/Image/resolveAssetSourcefrom react native because it will soon not be allowed: react-native-community/discussions-and-proposals#894There are no changes in the runtime behavior.
test plan
Built the common package locally and installed it into a fresh expo go project. Rendering of icons worked.
that being said, I had to do some workarounds to get
pnpm installto finish successfully:Maybe I just missed some docs but at the first sight, this seems to be a hurdle for external contributors.