Add lts identifier support to shell "auto nvm use" script

[PatrickKing]

It's wonderful that .nvmrc supports LTS version identifiers like lts/dubnium, but at present the auto nvm use shell script with the project readme doesn't understand the .nvmrc file if this is used:

16:40 $ cd .
Version 'vlts/dubnium' not found - try `nvm ls-remote` to browse available versions.
N/A: version "vlts/dubnium -> N/A" is not yet installed.

You need to run "nvm install vlts/dubnium" to install it before using it.

Could support for these identifiers be added? Thanks!

[ljharb]

Wow, thanks, that’s a clear bug and oversight. Will definitely fix.

[ljharb]

@PatrickKing hmm, I can't reproduce this locally. Can you fill out the entire issue template, including nvm ls and nvm debug output?

[PatrickKing]

@ljharb You got it ...

MacOS 10.12.6

10:35 $ nvm debug
nvm --version: v0.34.0
$TERM_PROGRAM: Apple_Terminal
$SHELL: /usr/local/bin/bash
$SHLVL: 1
$HOME: /Users/patrickking
$NVM_DIR: '$HOME/.nvm'
$PATH: $HOME/.rvm/gems/ruby-2.5.3@mit/bin:$HOME/.rvm/gems/ruby-2.5.3@global/bin:$HOME/.rvm/rubies/ruby-2.5.3/bin:$HOME/.rvm/bin:$NVM_DIR/versions/node/v10.15.0/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/Sublime Text.app/Contents/SharedSupport/bin:$HOME/bin:/Applications/NetExtender.app/Contents/MacOS
$PREFIX: ''
$NPM_CONFIG_PREFIX: ''
$NVM_NODEJS_ORG_MIRROR: ''
$NVM_IOJS_ORG_MIRROR: ''
shell version: 'GNU bash, version 5.0.0(1)-release (x86_64-apple-darwin16.7.0)'
uname -a: 'Darwin 16.7.0 Darwin Kernel Version 16.7.0: Thu Jun 15 17:36:27 PDT 2017; root:xnu-3789.70.16~2/RELEASE_X86_64 x86_64'
OS version: Mac 10.12.6 16G29
curl: /usr/bin/curl, curl 7.54.0 (x86_64-apple-darwin16.0) libcurl/7.54.0 SecureTransport zlib/1.2.8
wget: not found
git: /usr/local/bin/git, git version 2.13.3
grep: /usr/bin/grep, grep (BSD grep) 2.5.1-FreeBSD
awk: /usr/bin/awk, awk version 20070501
sed: illegal option -- -
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]
sed: /usr/bin/sed, 
cut: illegal option -- -
usage: cut -b list [-n] [file ...]
       cut -c list [file ...]
       cut -f list [-s] [-d delim] [file ...]
cut: /usr/bin/cut, 
basename: illegal option -- -
usage: basename string [suffix]
       basename [-a] [-s suffix] string [...]
basename: /usr/bin/basename, 
rm: illegal option -- -
usage: rm [-f | -i] [-dPRrvW] file ...
       unlink file
rm: /bin/rm, 
mkdir: illegal option -- -
usage: mkdir [-pv] [-m mode] directory ...
mkdir: /bin/mkdir, 
xargs: illegal option -- -
usage: xargs [-0opt] [-E eofstr] [-I replstr [-R replacements]] [-J replstr]
             [-L number] [-n number [-x]] [-P maxprocs] [-s size]
             [utility [argument ...]]
xargs: /usr/bin/xargs, 
nvm current: v10.15.0
which node: $NVM_DIR/versions/node/v10.15.0/bin/node
which iojs: 
which npm: $NVM_DIR/versions/node/v10.15.0/bin/npm
npm config get prefix: $NVM_DIR/versions/node/v10.15.0
npm root -g: $NVM_DIR/versions/node/v10.15.0/lib/node_modules

Some of this output seems weird, I'm not sure why so many tools are complaining about being called with illegal options.

10:36 $ nvm ls
        v6.11.5
->     v10.15.0
default -> 6.11.5 (-> v6.11.5)
node -> stable (-> v10.15.0) (default)
stable -> 10.15 (-> v10.15.0) (default)
iojs -> N/A (default)
unstable -> N/A (default)
lts/* -> lts/dubnium (-> v10.15.0)
lts/argon -> v4.9.1 (-> N/A)
lts/boron -> v6.16.0 (-> N/A)
lts/carbon -> v8.15.0 (-> N/A)
lts/dubnium -> v10.15.0

NVM installed via the one-line curl command in the readme. In addition to a few extra items added to my path, I'm also running RVM, which makes changes to the path in some circumstances.

... but, after giving the auto nvm use script a quick read, it appears to be just adding 'v' to the version it finds in .nvmrc if it does not lead with 'v', it probably needs some special handling for the LTS case right?

[ljharb]

Ah, most likely. I didn’t realize you were using one of the auto-use-on-cd scripts. Is it one of the ones in the readme? nvm doesn’t contain that functionality; so a PR to fix the scripts in the readme would be appreciated.

[PatrickKing]

I attempted to put together a PR for this, the change to the script should be minor, but I'm curious about the outputs of nvm ls with various arguments ...

nvm-testing$ nvm ls lts/dubnium
            N/A
            N/A
nvm-testing$ nvm ls 10.15.0
            N/A

In particular, running nvm ls with an LTS label prints N/A twice if it isn't available. I can work around that, but it seems like a hack around an inconsistency elsewhere.

[ljharb]

I agree; that’s a separate problem that needs solving.

[ljharb]

However, instead of that, I’d look into using nvm version rather than that v thing.

[d4nyll]

I've added a new PR #2017 which takes into account more aliases than just lts/*

[agatsoh]

Is this fixed yet ?

[ljharb]

Yep, i think it’s closed by #2017.