Initiating mini.tabline setup after mini.base16 colorscheme setup does not color tablline properly.

[231tr0n]

Contributing guidelines

• I have read CONTRIBUTING.md
• I have read CODE_OF_CONDUCT.md
• I have updated 'mini.nvim' to latest version of the main branch

Module(s)

mini.base16, mini.tabline

Neovim version

0.12 (!at least latest Nightly build!)

Description

Setting base16 colorscheme and then initializing mini.tabline setup does not color the tabline properly.
It colors it properly if only done after mini.tabline setup initialization.

Reproduction

1. Use the following repro config

vim.cmd('echo "Installing `mini.nvim`" | redraw')
local mini_path = vim.fn.stdpath("data") .. "/site/pack/deps/start/mini.nvim"
local clone_cmd = { "git", "clone", "--depth=1", "https://github.com/nvim-mini/mini.nvim", mini_path }
vim.fn.system(clone_cmd)
vim.cmd('echo "`mini.nvim` is installed" | redraw')

vim.cmd("packadd mini.nvim")
require("mini.deps").setup()

vim.cmd.colorscheme("minicyan")
require("mini.tabline").setup()
-- vim.cmd.colorscheme("minicyan")

2. Open the repro config file using NVIM_APPNAME=repro nvim init.lua.
3. Observe the tabline color, it matches the background color. Now try setting colorscheme using :colorscheme minicyan. You can see that the tabline no longer matches the background color. It changes color.
4. This issue does not happen if in the config vim.cmd.colorscheme call is done after mini.tabline setup.

[231tr0n]

From what I suspect. Mini.tabline is not setting tabline color by default properly when initialized.

[echasnovski]

Thanks for the issue!

It was because 'mini.base16' essentially used vim.api.nvim_set_hl(0, 'MiniTablineFill', {}). This lead to clearing MiniTablineFill highlight group, which usually means that it is "invisible". But then during require('mini.tabline').setup() actual links are created and they do not agree with 'mini.base16'. Edit: Instead I think the main goal of 'mini.base16' was to indeed link to Normal but it didn't for some reason.

I've updated 'mini.base16' (and 'mini.hues') to never use {} for plugin highlight groups to avoid situation from this issue. Should now be fixed on latest main.

[231tr0n]

From what I suspect. Mini.tabline is not setting tabline color by default properly when initialized.

Well it seems my debugging skills were off the charts. I seem to have to pointed you in the wrong direction. Sorry for the wrong take. I was so sure that this was a mini.tabline issue lol.

[echasnovski]

From what I suspect. Mini.tabline is not setting tabline color by default properly when initialized.

Well it seems my debugging skills were off the charts. I seem to have to pointed you in the wrong direction. Sorry for the wrong take. I was so sure that this was a mini.tabline issue lol.

No worries. It was a very small detour which I would probably do either way to see which link should 'mini.base16' use.