You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(completion): update 'completionItem/resolve' to always fall back
Details:
- Currently the 'completionItem/resolve' response falls back on the
original LSP item only in case there was an explicit error. Which is a
reasonable expectation (either error or response is not `nil`), but it
seems to not be the case for some servers (and even not really a
violation of the strict interpretation of the LSP specification).
As 'completionItem/resolve' is a request that is intended to update
an LSP completion item (used as argument), it is natural to always
try to use it if the server didn't return its updated variant (for
whatever reason).
Resolve#2090Resolve#1991 (probably)
0 commit comments