feat(hues): adjust Pmenu based on 'pumborder' value (on Neovim>=0.12)

Author: echasnovski

CHANGELOG.md

@@ -113,7 +113,9 @@ There are following change types:
 
 ### Evolve
 
-- Add auto adjusting of highlight groups based on certain events (like `MsgSeparator` group based on changing of `msgsep` flag of 'fillchars' option). It can be disabled via new `autoadjust` config setting or `opts.autoadjust` in `apply_palette()`.
+- Add auto adjusting of highlight groups based on certain events. It can be disabled via new `autoadjust` config setting or `opts.autoadjust` in `apply_palette()`. Affected groups:
+    - `MsgSeparator` depends on `msgsep` flag of 'fillchars' option.
+    - `Pmenu` depends on 'pumborder' option value (on Neovim>=0.12).
 
 ### Refine
 

doc/mini-hues.txt

@@ -207,6 +207,11 @@ events relevant to them. Currently adjusted groups:
 - |hl-MsgSeparator| is adjusted based on `msgsep` flag in |'fillchars'|.
   If it is whitespace - highlight background, otherwise - foreground.
 
+- |hl-Pmenu| is adjusted based on |'pumborder'| value (on Neovim>=0.12).
+  If it results in a border - same as floating window (but with no accent
+  in border), otherwise - same as |hl-CursorLine|. This design
+  makes |ins-completion-menu| stand out from regular floating windows.
+
 # Examples ~
 *MiniHues-examples*
 

lua/mini/hues.lua

@@ -194,6 +194,11 @@ end
 --- - |hl-MsgSeparator| is adjusted based on `msgsep` flag in |'fillchars'|.
 ---   If it is whitespace - highlight background, otherwise - foreground.
 ---
+--- - |hl-Pmenu| is adjusted based on |'pumborder'| value (on Neovim>=0.12).
+---   If it results in a border - same as floating window (but with no accent
+---   in border), otherwise - same as |hl-CursorLine|. This design
+---   makes |ins-completion-menu| stand out from regular floating windows.
+---
 --- # Examples ~
 --- *MiniHues-examples*
 ---
@@ -516,7 +521,8 @@ MiniHues.apply_palette = function(palette, plugins, opts)
   hi('NormalFloat',    { fg=p.fg,      bg=p.bg_edge })
   hi('NormalNC',       { link='Normal' })
   hi('OkMsg',          { fg=p.green,   bg=nil })
-  hi('Pmenu',          { fg=p.fg,      bg=p.bg_mid })
+  hi('Pmenu',          H.attr_pmenu(p, autoadjust))
+  hi('PmenuBorder',    { link='Pmenu' })
   hi('PmenuExtra',     { link='Pmenu' })
   hi('PmenuExtraSel',  { link='PmenuSel' })
   hi('PmenuKind',      { link='Pmenu' })
@@ -1950,6 +1956,7 @@ H.setup_autoadjust = function(palette)
   local adjust = function(ev)
     local adjust_all = ev.event == 'VimEnter'
     if adjust_all or ev.match == 'fillchars' then hi('MsgSeparator', H.attr_msgseparator(palette, true)) end
+    if adjust_all or ev.match == 'pumborder' then hi('Pmenu', H.attr_pmenu(palette, true)) end
   end
 
   -- Use single autocommand without pattern for performance (skips Neovim doing
@@ -1964,6 +1971,11 @@ H.attr_msgseparator = function(p, autoadjust)
   return vim.o.fillchars:find('msgsep:%S') ~= nil and { fg = p.accent } or { bg = p.bg_mid }
 end
 
+H.attr_pmenu = function(p, autoadjust)
+  local is_pumborder = vim.fn.exists('+pumborder') == 1 and not (vim.o.pumborder == '' or vim.o.pumborder == 'none')
+  return (autoadjust and is_pumborder) and { link = 'NormalFloat' } or { fg = p.fg, bg = p.bg_mid }
+end
+
 -- Utilities ------------------------------------------------------------------
 H.error = function(msg) error('(mini.hues) ' .. msg, 0) end
 

scripts/minimal_init.lua

@@ -4,7 +4,7 @@ vim.cmd([[let &rtp.=','.getcwd()]])
 
 -- Ensure persistent color scheme (matters after new default in Neovim 0.10)
 vim.o.background = 'dark'
-require('mini.hues').setup({ background = '#11262d', foreground = '#c0c8cc' })
+require('mini.hues').setup({ background = '#11262d', foreground = '#c0c8cc', autoadjust = false })
 vim.g.colors_name = 'minitest-scheme'
 
 -- - Make screenshot tests more robust across Neovim versions

tests/test_hues.lua

@@ -240,6 +240,17 @@ T['setup()']['respects `config.autoadjust`'] = function()
   validate_hl_group('MsgSeparator', 'guifg=#dddddd guibg=#3e3e3e')
   child.o.fillchars = 'msgsep: '
   validate_hl_group('MsgSeparator', 'guifg=#dddddd guibg=#3e3e3e')
+
+  -- Should autoadjust `Pmenu` based on 'pumborder'
+  if child.fn.has('nvim-0.12') == 1 then
+    child.cmd('highlight clear')
+    child.o.pumborder = 'single'
+    load_module({ background = '#222222', foreground = '#dddddd' })
+    validate_hl_group('Pmenu', 'links to NormalFloat')
+
+    child.o.pumborder = 'none'
+    validate_hl_group('Pmenu', 'guifg=#dddddd guibg=#3e3e3e')
+  end
 end
 
 T['make_palette()'] = new_set()