🔧 Fix GPG fingerprint verification in verify_signatures job#115
🔧 Fix GPG fingerprint verification in verify_signatures job#115
Conversation
- Apply same whitespace normalization fix to verify_signatures job - Use tr -s and xargs to handle GPG's variable spacing output - Add debug output to show expected vs actual fingerprints - Resolves GPG fingerprint verification failure in signature verification step
🔒 Security Audit Report❌ Error parsing audit report Could not parse security audit results. Check the logs for details. Security audit performed by cargo-audit |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- Change from '^\s+[0-9A-F]{4} [0-9A-F]{4}' to '^\s+([0-9A-F]{4}\s*){10}'
- Previous pattern only matched first 8 characters (2 groups) of fingerprint
- New pattern matches all 40 characters (10 groups of 4) of full fingerprint
- Prevents potential false positives from partial fingerprint matches
- Addresses Copilot code review feedback about incomplete fingerprint matching
🔒 Security Audit Report❌ Error parsing audit report Could not parse security audit results. Check the logs for details. Security audit performed by cargo-audit |
There was a problem hiding this comment.
Pull Request Overview
Fixes GPG fingerprint verification failures in the verify_signatures job by applying consistent whitespace normalization to address spacing inconsistencies in GPG output.
- Updates GPG fingerprint extraction pattern to handle variable spacing in GPG output
- Replaces direct grep matching with normalized string comparison using extracted variables
- Adds debug output to show expected vs actual fingerprints for troubleshooting
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- Update version in Cargo.toml and Cargo.lock - Prepare for next release with improved GPG fingerprint verification
🔒 Security Audit Report❌ Error parsing audit report Could not parse security audit results. Check the logs for details. Security audit performed by cargo-audit |
📊 Performance Test ReportTest Environment: Ubuntu Latest (GitHub Actions) 📏 Binary Size Analysis (AC8.2)
🧠 Memory Usage Analysis (AC8.3)
⚡ Performance Benchmarks
📈 Performance Summary
Full benchmark results available in workflow artifacts. |
Summary
Fixes the second instance of GPG fingerprint verification failure in the verify_signatures job by applying the same whitespace normalization fix.
Problem
The verify_signatures job was failing with the same whitespace issue:
Solution
Applied the same robust fingerprint verification pattern with spacing normalization.
Type of Change
☑ Bug fix (non-breaking change which fixes an issue)