🔧 Fix GPG fingerprint verification robustness#113
Conversation
- Normalize spacing in fingerprint comparison - Add debug output to show expected vs actual fingerprints - Handle GPG's variable spacing in fingerprint output - Use tr -s and xargs to normalize whitespace
There was a problem hiding this comment.
Pull Request Overview
This PR fixes GPG fingerprint verification failures in the release workflow by improving the robustness of spacing normalization when comparing fingerprints. The issue was caused by GPG outputting fingerprints with variable spacing that didn't match the expected exact string comparison.
- Replaces simple grep-based matching with regex extraction and spacing normalization
- Adds debug output to display expected vs actual fingerprints for troubleshooting
- Uses
tr -sandxargsto consistently normalize whitespace in fingerprint strings
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
🔒 Security Audit Report❌ Error parsing audit report Could not parse security audit results. Check the logs for details. Security audit performed by cargo-audit |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- Update version in Cargo.toml and Cargo.lock - Prepare for next release after GPG fingerprint fix
🔒 Security Audit Report❌ Error parsing audit report Could not parse security audit results. Check the logs for details. Security audit performed by cargo-audit |
📊 Performance Test ReportTest Environment: Ubuntu Latest (GitHub Actions) 📏 Binary Size Analysis (AC8.2)
🧠 Memory Usage Analysis (AC8.3)
⚡ Performance Benchmarks
📈 Performance Summary
Full benchmark results available in workflow artifacts. |
Summary
Fixes GPG fingerprint verification failure in the release workflow by improving spacing normalization.
☑ Normalize spacing in fingerprint comparison to handle GPG's variable output format
☑ Add debug output to show expected vs actual fingerprints for easier troubleshooting
☑ Use
tr -sandxargsto normalize whitespace consistentlyProblem
The release workflow was failing during GPG fingerprint verification because:
❌ Public key fingerprint verification failedExpected:
02D1 B70C F6D8 41EE E687 6E13 F7A6 F833 1CBB C51FActual:
02D1 B70C F6D8 41EE E687 6E13 F7A6 F833 1CBB C51F(note double space)Solution
tr -s ' 'andxargsTesting
Type of Change
☑ Bug fix (non-breaking change which fixes an issue)
☐ New feature (non-breaking change which adds functionality)
☐ Breaking change (fix or feature that would cause existing functionality to not work as expected)
☐ Documentation update
☐ Chore/cleanup (non-breaking change that doesn't add features or fix bugs)