Merge pull request #411 from manfred-brands/issues/410_nunit2044_false_positive

NUnit2044: Check type of operation instead.

Author: mikkelbu

src/nunit.analyzers.tests/DelegateRequired/DelegateRequiredAnalyzerTests.cs

@@ -46,6 +46,32 @@ public void AnalyzeWhenDelegateProvided()
             RoslynAssert.Valid(analyzer, testCode);
         }
 
+        [Test]
+        public void AnalyzeWhenDelegateLocalProvided()
+        {
+            var testCode = TestUtility.WrapInTestMethod(@"
+                TestDelegate action = MyOperation;
+                Assert.That(action, Throws.InvalidOperationException);
+
+                static void MyOperation() => throw new InvalidOperationException();
+            ");
+
+            RoslynAssert.Valid(analyzer, testCode);
+        }
+
+        [Test]
+        public void AnalyzeWhenDelegateParameterProvided()
+        {
+            var testCode = TestUtility.WrapInTestMethod(@"
+                AssertSupported(MyOperation);
+
+                static void AssertSupported(Action test) => Assert.That(test, Throws.InvalidOperationException);
+                static void MyOperation() => throw new InvalidOperationException();
+            ");
+
+            RoslynAssert.Valid(analyzer, testCode);
+        }
+
         [Test]
         public void AnalyzeWhenAsyncDelegateProvided()
         {

src/nunit.analyzers/DelegateRequired/DelegateRequiredAnalyzer.cs

@@ -31,7 +31,7 @@ protected override void AnalyzeAssertInvocation(OperationAnalysisContext context
                 return;
             }
 
-            if (actualOperation is IDelegateCreationOperation)
+            if (actualOperation.Type.TypeKind == TypeKind.Delegate)
             {
                 return;
             }