src: add appropriate coverage ignore on C++ code for Python type creation and memory allocation

Those branches cannot be meaningfully tested.

Author: MatthieuDartiailh

atom/src/atomdict.cpp

@@ -84,7 +84,7 @@ PyObject* AtomDict_new( PyTypeObject* type, PyObject* args, PyObject* kwargs )
 	cppy::ptr self( PyDict_Type.tp_new( type, args, kwargs ) );
 	if( !self )
 	{
-		return 0;
+		return 0;  // LCOV_EXCL_LINE (failed instance creation)
 	}
     atomdict_cast( self.get() )->pointer = new CAtomPointer();
     return self.release();
@@ -437,7 +437,7 @@ PyObject* DefaultAtomDict::New( CAtom* atom, Member* key_validator, Member* valu
     cppy::ptr self( PyDict_Type.tp_new( DefaultAtomDict::TypeObject, 0, 0 ) );
 	if( !self )
 	{
-		return 0;
+		return 0;  // LCOV_EXCL_LINE (failed instance creation)
 	}
     cppy::xincref( pyobject_cast( key_validator ) );
     atomdict_cast( self.get() )->m_key_validator = key_validator;
@@ -462,7 +462,7 @@ bool DefaultAtomDict::Ready()
 	);
     if( !TypeObject )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed type creation)
     }
     return true;
 }

atom/src/atomlist.cpp

@@ -41,7 +41,7 @@ namespace ListMethods
             if( strcmp( method->ml_name, name ) == 0 )
                 return method->ml_meth;
         }
-        return 0;
+        return 0;  // LCOV_EXCL_LINE (failed method lookup)
     }
 
     static bool
@@ -84,17 +84,17 @@ ListSubtype_New( PyTypeObject* subtype, Py_ssize_t size )
     if( size < 0 )
         return cppy::system_error( "negative list size" );
     if( static_cast<size_t>( size ) > PY_SSIZE_T_MAX / sizeof( PyObject* ) )
-        return PyErr_NoMemory();  // LCOV_EXCL_LINE
+        return PyErr_NoMemory();  // LCOV_EXCL_LINE (memory error)
     cppy::ptr ptr( PyType_GenericNew( subtype, 0, 0 ) );
     if( !ptr )
-        return 0;
+        return 0;  // LCOV_EXCL_LINE (failed instance creation)
     PyListObject* op = reinterpret_cast<PyListObject*>( ptr.get() );
     if( size > 0 )
     {
         size_t nbytes = size * sizeof( PyObject* );
         op->ob_item = reinterpret_cast<PyObject**>( PyMem_Malloc( nbytes ) );
         if( !op->ob_item )
-            return PyErr_NoMemory();  // LCOV_EXCL_LINE
+            return PyErr_NoMemory();  // LCOV_EXCL_LINE (memory error)
         memset( op->ob_item, 0, nbytes );
     }
 #if PY_VERSION_HEX >= 0x03090000
@@ -128,7 +128,7 @@ class AtomListHandler
             return 0;
         if( PyList_Append( m_list.get(), item.get() ) != 0 )
         {
-            return 0;
+            return 0;  // LCOV_EXCL_LINE (failed append, impossible)
         }
         return cppy::incref( Py_None );
     }
@@ -144,7 +144,7 @@ class AtomListHandler
             return 0;
         if( PyList_Insert( m_list.get(), index, valptr.get() ) != 0)
         {
-            return 0;
+            return 0;  // LCOV_EXCL_LINE (failed insert, impossible)
         }
         return cppy::incref( Py_None );
 
@@ -272,7 +272,7 @@ AtomList_new( PyTypeObject* type, PyObject* args, PyObject* kwargs )
     cppy::ptr ptr( PyList_Type.tp_new( type, args, kwargs ) );
     if( !ptr )
     {
-        return 0;
+        return 0;  // LCOV_EXCL_LINE (failed instance creation)
     }
     atomlist_cast( ptr.get() )->pointer = new CAtomPointer();
     return ptr.release();
@@ -439,13 +439,13 @@ AtomList::New( Py_ssize_t size, CAtom* atom, Member* validator )
 bool AtomList::Ready()
 {
     if( !ListMethods::init_methods() ) {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed method lookup, impossible)
     }
     // The reference will be handled by the module to which we will add the type
 	TypeObject = pytype_cast( PyType_FromSpec( &TypeObject_Spec ) );
     if( !TypeObject )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed type creation)
     }
     return true;
 }
@@ -497,122 +497,122 @@ init_containerlistchange()
     PySStr::typestr = PyUnicode_InternFromString( "type" );
     if( !PySStr::typestr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::namestr = PyUnicode_InternFromString( "name" );
     if( !PySStr::namestr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::objectstr = PyUnicode_InternFromString( "object" );
     if( !PySStr::objectstr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::valuestr = PyUnicode_InternFromString( "value" );
     if( !PySStr::valuestr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::operationstr = PyUnicode_InternFromString( "operation" );
     if( !PySStr::operationstr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::itemstr = PyUnicode_InternFromString( "item" );
     if( !PySStr::itemstr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::itemsstr = PyUnicode_InternFromString( "items" );
     if( !PySStr::itemsstr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::indexstr = PyUnicode_InternFromString( "index" );
     if( !PySStr::indexstr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::keystr = PyUnicode_InternFromString( "key" );
     if( !PySStr::keystr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::reversestr = PyUnicode_InternFromString( "reverse" );
     if( !PySStr::reversestr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::containerstr = PyUnicode_InternFromString( "container" );
     if( !PySStr::containerstr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::__delitem__str = PyUnicode_InternFromString( "__delitem__" );
     if( !PySStr::typestr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::__iadd__str = PyUnicode_InternFromString( "__iadd__" );
     if( !PySStr::__iadd__str )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::__imul__str = PyUnicode_InternFromString( "__imul__" );
     if( !PySStr::__imul__str )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::__setitem__str = PyUnicode_InternFromString( "__setitem__" );
     if( !PySStr::__setitem__str )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::appendstr = PyUnicode_InternFromString( "append" );
     if( !PySStr::appendstr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::extendstr = PyUnicode_InternFromString( "extend" );
     if( !PySStr::extendstr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::insertstr = PyUnicode_InternFromString( "insert" );
     if( !PySStr::insertstr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::popstr = PyUnicode_InternFromString( "pop" );
     if( !PySStr::popstr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::removestr = PyUnicode_InternFromString( "remove" );
     if( !PySStr::removestr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::sortstr = PyUnicode_InternFromString( "sort" );
     if( !PySStr::sortstr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::olditemstr = PyUnicode_InternFromString( "olditem" );
     if( !PySStr::olditemstr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::newitemstr = PyUnicode_InternFromString( "newitem" );
     if( !PySStr::newitemstr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     PySStr::countstr = PyUnicode_InternFromString( "count" );
     if( !PySStr::countstr )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed interned string creation)
     }
     alloced = true;
     return true;
@@ -1205,15 +1205,15 @@ bool AtomCList::Ready()
     // Ensure the parent type was created
     if( !AtomList::TypeObject )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (parent type not created, impossible)
     }
     AtomCList_Type_slots[0].pfunc = void_cast( AtomList::TypeObject );
 
     // The reference will be handled by the module to which we will add the type
 	TypeObject = pytype_cast( PyType_FromSpec( &TypeObject_Spec ) );
     if( !TypeObject )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed type creation)
     }
     return true;
 }

atom/src/atomref.cpp

@@ -186,7 +186,7 @@ bool AtomRef::Ready()
 	TypeObject = pytype_cast( PyType_FromSpec( &TypeObject_Spec ) );
     if( !TypeObject )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed type init)
     }
     return true;
 }

atom/src/atomset.cpp

@@ -31,7 +31,7 @@ init_methods()
     update = PyObject_GetAttrString( pyobject_cast( &PySet_Type ),  "update" );
     if( !update )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed to load set 'update' method, impossible)
     }
     return true;
 }
@@ -94,7 +94,7 @@ PyObject* AtomSet_new( PyTypeObject* type, PyObject* args, PyObject* kwargs )
     cppy::ptr self( PySet_Type.tp_new( type, args, kwargs ) );
 	if( !self )
 	{
-		return 0;
+		return 0;  // LCOV_EXCL_LINE (failed instance creation)
 	}
     atomset_cast( self.get() )->pointer = new CAtomPointer();
     return self.release();
@@ -330,7 +330,7 @@ PyObject* AtomSet::New( CAtom* atom, Member* validator )
     cppy::ptr self( PySet_Type.tp_new( AtomSet::TypeObject, 0, 0 ) );
 	if( !self )
 	{
-		return 0;
+		return 0;  // LCOV_EXCL_LINE (failed instance creation)
 	}
     cppy::xincref( pyobject_cast( validator ) );
     atomset_cast( self.get() )->m_value_validator = validator;
@@ -369,13 +369,13 @@ int AtomSet::Update( AtomSet* set, PyObject* value )
 bool AtomSet::Ready()
 {
 	if( !SetMethods::init_methods() ) {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed method lookup, impossible)
     }
     // The reference will be handled by the module to which we will add the type
 	TypeObject = pytype_cast( PyType_FromSpec( &TypeObject_Spec ) );
     if( !TypeObject )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed type creation)
     }
     return true;
 }

atom/src/catom.cpp

@@ -561,17 +561,17 @@ bool CAtom::Ready()
 	TypeObject = pytype_cast( PyType_FromSpec( &TypeObject_Spec ) );
     if( !TypeObject )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed type init)
     }
     atom_members = PyUnicode_InternFromString( "__atom_members__" );
     if( !atom_members )
     {
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed to intern string, impossible)
     }
 
     atom_flags = PyUnicode_InternFromString( "--frozen" );
     if( !atom_flags )
-        return false;
+        return false;  // LCOV_EXCL_LINE (failed to intern string, impossible)
 
     return true;
 }