Skip to content

When a Map has a non-indexable key, use a Map (plus refactoring and version bumps) #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

When a Map has a non-indexable key, use a Map (plus refactoring and version bumps) #39

wants to merge 17 commits into from

Conversation

@aSemy
Copy link

@aSemy aSemy commented Jan 5, 2022 •
edited
Loading

Hey, so there are lots of changes in this PR. I recognise there's quite a lot, and so if you'd like I can break them down into smaller PRs so they can be reviewed step-by-step. But first I thought I'd send over the end result rather than flooding you with lots of small PRs!

In summary:

  • upgrade versions (Gradle, Kotlin, Spek, Junit)
  • add the qoomon.git-versioning plugin (the project's version will be determined by the git tag of the current commit)
  • Migrate Gradle to .kts
  • apply some project config files (git config, gitignore, editor config)
  • some refactoring
    • split up test classes
    • standardise code style
    • remove un-used code
  • added more test cases
  • added Jacoco code coverage
  • if a Map<> has a non-indexable key, use an ES6 Map (Resolves Kotlin Maps with non-string non-numeric keys should map to Map instead of an Object #16)

aSemy added 16 commits January 5, 2022 00:08
@aSemy
update to gradle 7.3.3
7bd3928
@aSemy
start migrating Gradle to kts...
8df370a
@aSemy
- migrate gradle to kts
fcdab62 
- update versions
  - kotlin 1.6.10
  - findbugs to 3.0.2
  - junit 5.8.3
- add jacoco code coverage
- centralized repository definitions in settings.gradle.kts
@aSemy
update gradle distribution type to 'ALL'
4a88e35
@aSemy
fix code warnings
13a01a6
@aSemy
delete unused method
4927366
@aSemy
version bump
f9f7f12
@aSemy
use git tags to determine the version of the project (supplements Jit…
0727c37 
…Pack very nicely)
@aSemy
add some git/formatting project config files
8f59aac
@aSemy
apply project formatter
0a51b86
@aSemy
break up tests into smaller test classes
04e23dd
@aSemy
- merge Map<> tests into TestCollectionFields.kt
a9473e2 
- add test for Set<>
- add tests for primitive arrays
@aSemy
rename test support classes for clarity
4838652
@aSemy
a litle bit of code tidying
e633178
@aSemy
- migrate to spek2
082c468 
- remove 'expekt', replace with JUnit assertion
@aSemy
resolve issue#16 - use an ES6 Map<> for non-string/number/enum keyed …
6a0c5e2 
…Maps.
This was referenced Jan 5, 2022
Closed
Merged
@commandblock2 commandblock2 mentioned this pull request Jan 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Kotlin Maps with non-string non-numeric keys should map to Map instead of an Object

1 participant

@aSemy