-
Notifications
You must be signed in to change notification settings - Fork 277
Implemented #634: Arg.AnyType can be used in place of a generic type parameter
#715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a6d9022
Implemented #634: `Arg.AnyType` can be used in place of a generic typ…
icalvo 055fb2b
Throw when Do<AnyType>. Fixed CompatArg.
icalvo 93e2524
Fixed RedundantArgumentMatcherException
icalvo ce6793b
Solve `DoForAny` issue with an overload.
icalvo 5cf222b
Removed unused DoAnyTypeException
icalvo 10f0da5
Convert fake build to use build project
dtchepak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| namespace NSubstitute.Exceptions; | ||
|
|
||
| public class DoAnyTypeException : SubstituteException | ||
| { | ||
| private const string FixedMessage = "Use DoForAny() instead of Do<AnyType>()"; | ||
| public DoAnyTypeException() : base(FixedMessage) { } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using NSubstitute.Exceptions; | ||
| using NUnit.Framework; | ||
|
|
||
| namespace NSubstitute.Acceptance.Specs; | ||
|
|
||
| [TestFixture] | ||
| public class GenericArguments | ||
| { | ||
| public interface ISomethingWithGenerics | ||
| { | ||
| void Log<TState>(int level, TState state); | ||
| } | ||
|
|
||
| [Test] | ||
| public void Return_result_for_any_argument() | ||
| { | ||
| string argDoResult = null; | ||
| int? whenDoResult = null; | ||
| bool whenDoCalled = false; | ||
| ISomethingWithGenerics something = Substitute.For<ISomethingWithGenerics>(); | ||
| something.Log(Arg.Any<int>(), Arg.Do<Arg.AnyType>(a => argDoResult = ">>" + ((int)a).ToString("P"))); | ||
| something | ||
| .When(substitute => substitute.Log(Arg.Any<int>(), Arg.Any<Arg.AnyType>())) | ||
| .Do(info => | ||
| { | ||
| whenDoResult = info.ArgAt<int>(1); | ||
| whenDoCalled = true; | ||
| }); | ||
|
|
||
| something.Log(7, 3409); | ||
|
|
||
| something.Received().Log(Arg.Any<int>(), Arg.Any<Arg.AnyType>()); | ||
| something.Received().Log(7, 3409); | ||
| Assert.That(whenDoCalled, Is.True); | ||
| Assert.That(argDoResult, Is.EqualTo(">>340 900.00 %")); | ||
| Assert.That(whenDoResult, Is.EqualTo(3409)); | ||
| } | ||
| } |
7 changes: 7 additions & 0 deletions
7
tests/NSubstitute.Acceptance.Specs/Infrastructure/ISomethingWithGenericMethods.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| namespace NSubstitute.Acceptance.Specs.Infrastructure; | ||
|
|
||
| public interface ISomethingWithGenericMethods | ||
| { | ||
| void Log<TState>(int level, TState state); | ||
| string Format<T>(T state); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.