Cannot read properties of undefined (reading 'data')

[SirPhemmiey]

Current Behavior

When usingyarn as package manager and trying to build a project that contains "generatePackageJson": true option, build target is failing

Expected Behavior

It should build

GitHub Repo

No response

Steps to Reproduce

1. Include generatePackageJson in your target build project.json
2. run yarn build <project>

Nx Report

Node   : 20.9.0
OS     : darwin-arm64
yarn   : 1.22.19

nx (global)        : 17.0.3
nx                 : 18.1.2
@nx/js             : 18.1.2
@nx/jest           : 18.1.2
@nx/linter         : 18.0.8
@nx/eslint         : 18.0.8
@nx/workspace      : 18.1.2
@nx/cypress        : 18.1.2
@nx/devkit         : 18.1.2
@nx/eslint-plugin  : 18.1.2
@nx/nest           : 18.1.2
@nx/node           : 18.1.2
@nx/plugin         : 18.1.2
@nx/react          : 18.1.2
@nx/rollup         : 18.1.2
@nrwl/tao          : 18.1.2
@nx/web            : 18.1.2
@nx/webpack        : 18.1.2
typescript         : 5.3.3

Failure Logs

TypeError: Cannot read properties of undefined (reading 'data')
    at /Users/oluwafem.iakinde/Documents/adtech-monorepo/node_modules/nx/src/plugins/js/package-json/create-package-json.js:124:55
    at Array.forEach (<anonymous>)
    at findProjectsNpmDependencies (/Users/oluwafem.iakinde/Documents/adtech-monorepo/node_modules/nx/src/plugins/js/package-json/create-package-json.js:122:33)
    at createPackageJson (/Users/oluwafem.iakinde/Documents/adtech-monorepo/node_modules/nx/src/plugins/js/package-json/create-package-json.js:23:21)
    at /Users/oluwafem.iakinde/Documents/adtech-monorepo/node_modules/@nx/webpack/src/plugins/generate-package-json-plugin.js:30:64
    at fn (/Users/oluwafem.iakinde/Documents/adtech-monorepo/node_modules/webpack/lib/Compilation.js:478:10)
    at Hook.eval [as callAsync] (eval at create (/Users/oluwafem.iakinde/Documents/adtech-monorepo/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:10:1)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/Users/oluwafem.iakinde/Documents/adtech-monorepo/node_modules/tapable/lib/Hook.js:18:14)
    at cont (/Users/oluwafem.iakinde/Documents/adtech-monorepo/node_modules/webpack/lib/Compilation.js:3059:34)
    at /Users/oluwafem.iakinde/Documents/adtech-monorepo/node_modules/webpack/lib/Compilation.js:3107:10

Package Manager Version

1.22.19

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

It's the same issue as this: #17450

[SirPhemmiey]

I will be closing this as i've found out that simply updating webpack to the latest version will most likely fix this. Current version is v5.91.0

[SirPhemmiey]

I reopened this again because i had to remove yarn.lock from .nxignore for it to work. I initially added yarn.lock to .nxignore because of this

[meeroslav]

Hi @SirPhemmiey, the issue you see above is caused by our parser being unable to properly prune the lock file.

In order to debug this issue, can you please create a small reproduction repo?

[github-actions]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

[treefitty]

I've just run into this issue too, completely out of the blue. I can stash my current changes and it will build, unstash and I get this error building my nestjs app and generating package json.

Summary of my project:

• Macos
• Nx 18.3.3
• Node 20.5.1
• Pnpm 9.0.4
• Webpack (@nx/webpack 18.3.3)
• SWC (core 1.4.16, helpers 0.5.10)

Summary of what I know regarding the problem context:

• I've upgraded webpack and all other dependencies I can think of
• It seems to have been triggered by adding MSW, although the NestJS project does not reference it
• It's happening in findProjectsNpmDependencies on line 124

- `dep` has a value of `npm:tslib` - `npmDeps.dependencies` is an empty object

Not sure if I could create a reproducible given the fragiligty of this instance, however if someone wants to help me get more information about this I'm more than happy to help!

[treefitty]

adding more context through my extremely naive debugging...

The graph.externalNodes object is huge (expected) and has the following tslib keys:

Which makes sense why npm:tslib is not matching

Also, options.helperDependencies only contains npm:tslib and nothing else