chore: remove backward compatiblity tests

read-package-json and read-package-json-fast test were initially put in place to ensure this package was fully compatible.

This package is now used almost everywhere in npm, and the things we are adding to finish the removal of those other packages is MORE correct here than in those old packages, so the tests won't even work anymore.

Author: wraithgar

test/normalize.js

@@ -1,7 +1,5 @@
 const t = require('tap')
-const { join } = require('node:path')
 const pkg = require('../')
-const rpj = require('read-package-json-fast')
 
 const testMethods = {
   // eslint-disable-next-line max-len
@@ -17,15 +15,9 @@ const testMethods = {
     const p = t.testdir(testdir)
     return pkg.normalize(dir(p), opts)
   },
-  'read-package-json-fast': (t, testdir = {}, { dir = (v) => v } = {}) => {
-    const p = t.testdir(testdir)
-    return rpj(join(dir(p), 'package.json')).then(r => ({ content: r }))
-  },
 }
 
 for (const [name, testNormalize] of Object.entries(testMethods)) {
-  const isLegacy = name === 'read-package-json-fast'
-
   t.test(name, async t => {
     t.test('errors for bad/missing data', async t => {
       t.test('raises an error for missing file', t =>
@@ -352,9 +344,6 @@ for (const [name, testNormalize] of Object.entries(testMethods)) {
     })
 
     t.test('skipping steps', async t => {
-      if (isLegacy) {
-        return t.skip('rpj does not have configurable steps')
-      }
       const packageJson = {
         _lodash: true,
         dependencies: { a: '' },

test/prepare.js

@@ -16,25 +16,9 @@ const testMethods = {
     res.logs = logs
     return res
   },
-  'read-package-json': (t, testdir, { dir = (v) => v } = {}) => {
-    const p = t.testdir(testdir)
-    const rpj = t.mock('read-package-json') // reset rpj caches
-    const logs = []
-    const logger = (...a) => logs.push(a.slice(1))
-    return new Promise((res, rej) => {
-      rpj(join(dir(p), 'package.json'), logger, (err, content) => {
-        if (err) {
-          rej(err)
-        } else {
-          res({ content, logs })
-        }
-      })
-    })
-  },
 }
 
 for (const [name, testPrepare] of Object.entries(testMethods)) {
-  const isLegacy = name === 'read-package-json'
   t.test(name, async t => {
     t.test('errors for bad/missing data', async t => {
       t.test('invalid version', t =>
@@ -562,8 +546,7 @@ for (const [name, testPrepare] of Object.entries(testMethods)) {
             testgitref: 'filegitref',
           },
         }), { dir: (p) => join(p, 'sub'), root: true })
-        // rpj has no way prevent walking up all directories
-        t.strictSame(content.gitHead, isLegacy ? 'filegitref' : undefined)
+        t.strictSame(content.gitHead, undefined)
       })
       t.end()
     })
@@ -653,9 +636,6 @@ for (const [name, testPrepare] of Object.entries(testMethods)) {
     })
 
     t.test('skipping steps', async t => {
-      if (isLegacy) {
-        return t.skip('rpj does not have configurable steps')
-      }
       const packageJson = {
         scripts: { test: './node_modules/.bin/test' },
         main: './custom-path.js',
@@ -732,13 +712,9 @@ for (const [name, testPrepare] of Object.entries(testMethods)) {
           readme: 'ERROR: No README data found!',
           gitHead: 'testgitref',
         })
-        if (isLegacy) {
-          t.skip('rpj does not save files')
-        } else {
-          await t.rejects(parsed.save(), {
-            message: /No package.json/,
-          })
-        }
+        await t.rejects(parsed.save(), {
+          message: /No package.json/,
+        })
       })
       t.end()
     })