fixup!: fast path for compareIdentifiers when num

Author: wraithgar

classes/semver.js

@@ -107,15 +107,30 @@ class SemVer {
   }
 
   compareMain (other) {
+    // XXX compare already did this
     if (!(other instanceof SemVer)) {
       other = new SemVer(other, this.options)
     }
 
-    return (
-      compareIdentifiers(this.major, other.major) ||
-      compareIdentifiers(this.minor, other.minor) ||
-      compareIdentifiers(this.patch, other.patch)
-    )
+    if (this.major < other.major) {
+      return -1
+    }
+    if (this.major > other.major) {
+      return 1
+    }
+    if (this.minor < other.minor) {
+      return -1
+    }
+    if (this.minor > other.minor) {
+      return 1
+    }
+    if (this.patch < other.patch) {
+      return -1
+    }
+    if (this.patch > other.patch) {
+      return 1
+    }
+    return 0
   }
 
   comparePre (other) {

internal/identifiers.js

@@ -2,10 +2,6 @@
 
 const numeric = /^[0-9]+$/
 const compareIdentifiers = (a, b) => {
-  if (typeof a === 'number' && typeof b === 'number') {
-    return a === b ? 0 : a < b ? -1 : 1
-  }
-  
   const anum = numeric.test(a)
   const bnum = numeric.test(b)