fix(config): use exclusive for save types

Author: owlstronaut

workspaces/config/lib/definitions/definitions.js

@@ -1695,10 +1695,16 @@ const definitions = {
     default: false,
     type: Boolean,
     short: 'D',
+    exclusive: ['save-optional', 'save-peer', 'save-prod'],
     description: `
       Save installed packages to a package.json file as \`devDependencies\`.
     `,
     flatten (key, obj, flatOptions) {
+      if (obj['save-dev'] && obj['save-optional']) {
+        const msg = '--save-dev and --save-optional are mutually exclusive, last one wins'
+        log.warn('invalid', msg)
+      }
+
       if (!obj[key]) {
         if (flatOptions.saveType === 'dev') {
           delete flatOptions.saveType
@@ -1726,11 +1732,17 @@ const definitions = {
     default: false,
     type: Boolean,
     short: 'O',
+    exclusive: ['save-dev', 'save-peer', 'save-prod'],
     description: `
       Save installed packages to a package.json file as
       \`optionalDependencies\`.
     `,
     flatten (key, obj, flatOptions) {
+      if (obj['save-dev'] && obj['save-optional']) {
+        const msg = '--save-dev and --save-optional are mutually exclusive, last one wins'
+        log.warn('invalid', msg)
+      }
+
       if (!obj[key]) {
         if (flatOptions.saveType === 'optional') {
           delete flatOptions.saveType
@@ -1754,6 +1766,7 @@ const definitions = {
   'save-peer': new Definition('save-peer', {
     default: false,
     type: Boolean,
+    exclusive: ['save-dev', 'save-optional', 'save-prod'],
     description: `
       Save installed packages to a package.json file as \`peerDependencies\`
     `,
@@ -1799,6 +1812,7 @@ const definitions = {
     default: false,
     type: Boolean,
     short: 'P',
+    exclusive: ['save-dev', 'save-optional', 'save-peer'],
     description: `
       Save installed packages into \`dependencies\` specifically. This is
       useful if a package already exists in \`devDependencies\` or

workspaces/config/test/definitions/definitions.js

@@ -693,6 +693,35 @@ t.test('saveType', t => {
     t.end()
   })
 
+  t.test('save-dev && save-optional warn when used together', t => {
+    const warn = []
+    const base = require('proc-log')
+    const fakeLog = {
+      ...base.log,
+      warn: (...args) => warn.push(args),
+    }
+
+    const defs = mockDefs({
+      'proc-log': {
+        ...base,
+        log: fakeLog,
+      },
+    })
+
+    const obj = { 'save-dev': true, 'save-optional': true }
+    const flat = {}
+
+    defs['save-dev'].flatten('save-dev', obj, flat)
+    defs['save-optional'].flatten('save-optional', obj, flat)
+
+    t.strictSame(warn, [
+      ['invalid', '--save-dev and --save-optional are mutually exclusive, last one wins'],
+      ['invalid', '--save-dev and --save-optional are mutually exclusive, last one wins'],
+    ])
+
+    t.end()
+  })
+
   t.end()
 })