Skip to content

Commit 5961753

Browse files
stuartmorgan-gnploi
authored andcommitted
[ci] Add LUCI repo tool tests (flutter#3964)
- Adds a LUCI version of the Linux repo tools test, as a first test of a Linux repository test being migrated to LUCI. - Fixes the Windows repo tools test to actually run a test, which it wasn't due to a mistaken duplicate yaml file, only one of which was correct (the one that wasn't being used).
1 parent 3ee2a72 commit 5961753

4 files changed

Lines changed: 20 additions & 9 deletions

File tree

.ci.yaml

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,18 @@ platform_properties:
4444
xcode: 14e222b
4545

4646
targets:
47-
### iOS+macOS tasks ***
47+
### Linux tasks ###
48+
- name: Linux repo_tools_tests
49+
bringup: true # New target
50+
recipe: packages/packages
51+
timeout: 30
52+
properties:
53+
add_recipes_cq: "true"
54+
target_file: repo_tools_tests.yaml
55+
channel: master
56+
version_file: flutter_master.version
57+
58+
### iOS+macOS tasks ###
4859
# TODO(stuartmorgan): Move this to ARM once google_maps_flutter has ARM
4960
# support. `pod lint` makes a synthetic target that doesn't respect the
5061
# pod's arch exclusions, so fails to build.

.ci/targets/plugin_tools_tests.yaml

Lines changed: 0 additions & 5 deletions
This file was deleted.

.ci/targets/repo_tools_tests.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
tasks:
22
- name: prepare tool
33
script: .ci/scripts/prepare_tool.sh
4-
# TODO(stuartmorgan): Add actual tests here when moving the repo tooling.
4+
- name: tool unit tests
5+
script: .ci/scripts/plugin_tools_tests.sh

script/tool/test/publish_check_command_test.dart

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,9 @@ void main() {
283283
'Test for publish-check command.',
284284
);
285285
runner.addCommand(PublishCheckCommand(packagesDir,
286-
processRunner: processRunner, httpClient: mockClient));
286+
platform: mockPlatform,
287+
processRunner: processRunner,
288+
httpClient: mockClient));
287289

288290
processRunner.mockProcessesForExecutable['flutter'] = <FakeProcessInfo>[
289291
FakeProcessInfo(MockProcess(exitCode: 1, stdout: 'Some error from pub'),
@@ -339,7 +341,9 @@ void main() {
339341
'Test for publish-check command.',
340342
);
341343
runner.addCommand(PublishCheckCommand(packagesDir,
342-
processRunner: processRunner, httpClient: mockClient));
344+
platform: mockPlatform,
345+
processRunner: processRunner,
346+
httpClient: mockClient));
343347

344348
final List<String> output =
345349
await runCapturingPrint(runner, <String>['publish-check']);

0 commit comments

Comments
 (0)